Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-06 Thread Marton Balint
On Thu, 5 Dec 2019, Kusanagi Kouichi wrote: On 2019-12-04 22:32:52 +0100, Marton Balint wrote: On Wed, 4 Dec 2019, Kusanagi Kouichi wrote: > On 2019-12-03 21:25:37 +0100, Marton Balint wrote: > > > > > > On Tue, 3 Dec 2019, Kusanagi Kouichi wrote: > > > > > On 2019-11-19 22:59:56 +0900,

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-05 Thread Kusanagi Kouichi
On 2019-12-04 22:32:52 +0100, Marton Balint wrote: > > > On Wed, 4 Dec 2019, Kusanagi Kouichi wrote: > > > On 2019-12-03 21:25:37 +0100, Marton Balint wrote: > > > > > > > > > On Tue, 3 Dec 2019, Kusanagi Kouichi wrote: > > > > > > > On 2019-11-19 22:59:56 +0900, Kusanagi Kouichi wrote: > > >

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-04 Thread Marton Balint
On Wed, 4 Dec 2019, Kusanagi Kouichi wrote: On 2019-12-03 21:25:37 +0100, Marton Balint wrote: On Tue, 3 Dec 2019, Kusanagi Kouichi wrote: > On 2019-11-19 22:59:56 +0900, Kusanagi Kouichi wrote: > > Use AVBufferPool. You don't need a buffer pool for the non-shm case, you should wrap the X

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-03 Thread Kusanagi Kouichi
On 2019-12-03 21:25:37 +0100, Marton Balint wrote: > > > On Tue, 3 Dec 2019, Kusanagi Kouichi wrote: > > > On 2019-11-19 22:59:56 +0900, Kusanagi Kouichi wrote: > > > Use AVBufferPool. > > You don't need a buffer pool for the non-shm case, you should wrap the XCB > data in a buffer ref instead.

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-03 Thread Marton Balint
On Tue, 3 Dec 2019, Kusanagi Kouichi wrote: On 2019-11-19 22:59:56 +0900, Kusanagi Kouichi wrote: Use AVBufferPool. You don't need a buffer pool for the non-shm case, you should wrap the XCB data in a buffer ref instead. I will reply with a patch that shows how it is done, please check if

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-03 Thread Kusanagi Kouichi
On 2019-11-19 22:59:56 +0900, Kusanagi Kouichi wrote: > Use AVBufferPool. > > before: > $ ffmpeg -benchmark -f x11grab -video_size 1920x1200 -r 200 -t 3 -i +0,0 -f > null - > ... > frame= 600 fps=102 q=-0.0 Lsize=N/A time=00:00:03.00 bitrate=N/A speed=0.51x > video:314kB audio:0kB subtitle:0kB o

[FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-11-19 Thread Kusanagi Kouichi
Use AVBufferPool. before: $ ffmpeg -benchmark -f x11grab -video_size 1920x1200 -r 200 -t 3 -i +0,0 -f null - ... frame= 600 fps=102 q=-0.0 Lsize=N/A time=00:00:03.00 bitrate=N/A speed=0.51x video:314kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: unknown bench: u