Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-28 Thread Ray Tiley
On Sun, Jan 28, 2018 at 4:54 PM Marton Balint wrote: > > On Thu, 25 Jan 2018, Ray Tiley wrote: > > > On Tue, Jan 23, 2018 at 9:07 AM Devin Heitmueller < > > dheitmuel...@ltnglobal.com> wrote: > > > >> Hi Ray, > >> > >>> On Jan 22, 2018, at 11:20 PM, Ray Tiley wrote: > >>> > >>> I'm reading 334-1

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-28 Thread Marton Balint
On Thu, 25 Jan 2018, Ray Tiley wrote: On Tue, Jan 23, 2018 at 9:07 AM Devin Heitmueller < dheitmuel...@ltnglobal.com> wrote: Hi Ray, On Jan 22, 2018, at 11:20 PM, Ray Tiley wrote: I'm reading 334-1:2017 Sec 4 "When the ANC packets defined in this standard are carried in a high definition

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-25 Thread Ray Tiley
Apologies for attaching the patch, still trying to figure out patches, didn't know how to send the patch and include info in the email unrelated to commit message / change. The unpack_v210 is only called for SD resolutions ,specifically NTSC which is 720 wide. unpack_v210 should never be called fo

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-25 Thread Devin Heitmueller
Hi Ray, > > Please find updated patch attatched. I reverted the vanc lines changes and > found that all my tests worked as expected, so not sure what was wrong w/ > my original test. The need to extract vanc from the entire line vs just the > luma in NTSC is still required. It’s helpful if in th

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-24 Thread Ray Tiley
On Tue, Jan 23, 2018 at 9:07 AM Devin Heitmueller < dheitmuel...@ltnglobal.com> wrote: > Hi Ray, > > > On Jan 22, 2018, at 11:20 PM, Ray Tiley wrote: > > > > I'm reading 334-1:2017 Sec 4 > > "When the ANC packets defined in this standard are carried in a high > > definition signal, they shall be

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-23 Thread Devin Heitmueller
Hi Ray, > On Jan 22, 2018, at 11:20 PM, Ray Tiley wrote: > > I'm reading 334-1:2017 Sec 4 > "When the ANC packets defined in this standard are carried in a high > definition signal, they shall be carried in the Y stream." > > I couldn't find anywhere in the document where it calls out standard

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-22 Thread Ray Tiley
On Mon, Jan 22, 2018 at 11:12 PM Devin Heitmueller < dheitmuel...@ltnglobal.com> wrote: > Hi Ray, > > > On Jan 22, 2018, at 10:47 PM, Ray Tiley wrote: > >> Could you confirm whether you are capturing via SDI or analog (i.e. > >> composite/component)? Also what is the capturing device and SDK ver

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-22 Thread Devin Heitmueller
Hi Ray, > On Jan 22, 2018, at 10:47 PM, Ray Tiley wrote: >> Could you confirm whether you are capturing via SDI or analog (i.e. >> composite/component)? Also what is the capturing device and SDK version >> you are using? I’ve found various bugs in the numbering of VANC lines in >> some cards, p

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-22 Thread Ray Tiley
On Mon, Jan 22, 2018 at 10:20 PM Devin Heitmueller < dheitmuel...@ltnglobal.com> wrote: > Hi Ray, > > Thanks for your patch. A few questions: > > Could you confirm whether you are capturing via SDI or analog (i.e. > composite/component)? Also what is the capturing device and SDK version > you ar

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-22 Thread Devin Heitmueller
Hi Ray, Thanks for your patch. A few questions: Could you confirm whether you are capturing via SDI or analog (i.e. composite/component)? Also what is the capturing device and SDK version you are using? I’ve found various bugs in the numbering of VANC lines in some cards, particularly with

[FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-20 Thread Ray Tiley
This changes the vertical blanking lines extracted for NTSC and 1080i resolutions that in personal testing were required to extract closed caption data from the decklink video frames. Additionally NTSC resolutions have the vanc data interleved between the uyvy and not just the luma as in high defi