Re: [FFmpeg-devel] [PATCH] avcodec: remove av_codec_init_static()

2018-02-14 Thread James Almer
On 2/14/2018 2:09 AM, wm4 wrote: > On Wed, 14 Feb 2018 07:07:09 +0700 > Muhammad Faiz wrote: > >> On Tue, Feb 13, 2018 at 3:57 AM, wm4 wrote: >>> On Mon, 12 Feb 2018 12:42:10 +0700 >>> Muhammad Faiz wrote: >>> Modify the behavior of init_static_data(). Signed-off-by: Muhammad F

Re: [FFmpeg-devel] [PATCH] avcodec: remove av_codec_init_static()

2018-02-13 Thread wm4
On Wed, 14 Feb 2018 07:07:09 +0700 Muhammad Faiz wrote: > On Tue, Feb 13, 2018 at 3:57 AM, wm4 wrote: > > On Mon, 12 Feb 2018 12:42:10 +0700 > > Muhammad Faiz wrote: > > > >> Modify the behavior of init_static_data(). > >> > >> Signed-off-by: Muhammad Faiz > >> --- > > > > Seems OK, but I'

Re: [FFmpeg-devel] [PATCH] avcodec: remove av_codec_init_static()

2018-02-13 Thread Muhammad Faiz
On Tue, Feb 13, 2018 at 3:57 AM, wm4 wrote: > On Mon, 12 Feb 2018 12:42:10 +0700 > Muhammad Faiz wrote: > >> Modify the behavior of init_static_data(). >> >> Signed-off-by: Muhammad Faiz >> --- > > Seems OK, but I'm also not sure about the benefit. The fundamental > problem that these codecs nee

Re: [FFmpeg-devel] [PATCH] avcodec: remove av_codec_init_static()

2018-02-13 Thread Muhammad Faiz
On Tue, Feb 13, 2018 at 2:40 AM, James Almer wrote: > On 2/12/2018 2:42 AM, Muhammad Faiz wrote: >> Modify the behavior of init_static_data(). >> >> Signed-off-by: Muhammad Faiz >> --- >> libavcodec/allcodecs.c | 16 >> libavcodec/avcodec.h | 4 +++- >> libavcodec/libvpxdec.c

Re: [FFmpeg-devel] [PATCH] avcodec: remove av_codec_init_static()

2018-02-12 Thread wm4
On Mon, 12 Feb 2018 12:42:10 +0700 Muhammad Faiz wrote: > Modify the behavior of init_static_data(). > > Signed-off-by: Muhammad Faiz > --- Seems OK, but I'm also not sure about the benefit. The fundamental problem that these codecs need to mutate AVCodec before the users sees it won't go away

Re: [FFmpeg-devel] [PATCH] avcodec: remove av_codec_init_static()

2018-02-12 Thread James Almer
On 2/12/2018 2:42 AM, Muhammad Faiz wrote: > Modify the behavior of init_static_data(). > > Signed-off-by: Muhammad Faiz > --- > libavcodec/allcodecs.c | 16 > libavcodec/avcodec.h | 4 +++- > libavcodec/libvpxdec.c | 15 ++- > libavcodec/libvpxenc.c | 15

[FFmpeg-devel] [PATCH] avcodec: remove av_codec_init_static()

2018-02-11 Thread Muhammad Faiz
Modify the behavior of init_static_data(). Signed-off-by: Muhammad Faiz --- libavcodec/allcodecs.c | 16 libavcodec/avcodec.h | 4 +++- libavcodec/libvpxdec.c | 15 ++- libavcodec/libvpxenc.c | 15 ++- libavcodec/libx264.c | 11 ++- libavcode