Re: [FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-19 Thread James Almer
On 7/19/2018 6:16 PM, Carl Eugen Hoyos wrote: > 2018-07-19 21:47 GMT+02:00, James Almer : >> On 7/19/2018 4:31 PM, Nicolas George wrote: >>> James Almer (2018-07-19): This is more in line with the similar error above. Aborting gracefully by printing a message and returning an error value

Re: [FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-19 Thread Carl Eugen Hoyos
2018-07-19 21:47 GMT+02:00, James Almer : > On 7/19/2018 4:31 PM, Nicolas George wrote: >> James Almer (2018-07-19): >>> This is more in line with the similar error above. Aborting gracefully >>> by printing a message and returning an error value instead of a hard >>> abort() with no explanation as

Re: [FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-19 Thread James Almer
On 7/19/2018 4:31 PM, Nicolas George wrote: > James Almer (2018-07-19): >> This is more in line with the similar error above. Aborting gracefully >> by printing a message and returning an error value instead of a hard >> abort() with no explanation as to why "ret == AVERROR(ENOMEM)" was expected. >

Re: [FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-19 Thread Nicolas George
James Almer (2018-07-19): > This is more in line with the similar error above. Aborting gracefully > by printing a message and returning an error value instead of a hard > abort() with no explanation as to why "ret == AVERROR(ENOMEM)" was expected. Explaining to whom? If it is a consistency bug wi

Re: [FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-19 Thread Carl Eugen Hoyos
2018-07-19 21:00 GMT+02:00, Aman Gupta : > On Thu, Jul 19, 2018 at 11:44 AM Carl Eugen Hoyos > wrote: > >> 2018-07-19 3:37 GMT+02:00, James Almer : >> > On 7/18/2018 3:57 PM, Aman Gupta wrote: >> >> >> +ret = av_opt_set_from_string(s->bsfs[s->nb_bsfs - >> >> 1]->priv_data, bsf_options_

Re: [FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-19 Thread James Almer
On 7/19/2018 3:44 PM, Carl Eugen Hoyos wrote: > 2018-07-19 3:37 GMT+02:00, James Almer : >> On 7/18/2018 3:57 PM, Aman Gupta wrote: > >>> +ret = av_opt_set_from_string(s->bsfs[s->nb_bsfs - >>> 1]->priv_data, bsf_options_str, shorthand, "=", ":"); >>> +if (ret < 0) { >>> +

Re: [FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-19 Thread Aman Gupta
On Thu, Jul 19, 2018 at 11:44 AM Carl Eugen Hoyos wrote: > 2018-07-19 3:37 GMT+02:00, James Almer : > > On 7/18/2018 3:57 PM, Aman Gupta wrote: > > >> +ret = av_opt_set_from_string(s->bsfs[s->nb_bsfs - > >> 1]->priv_data, bsf_options_str, shorthand, "=", ":"); > >> +if (re

Re: [FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-19 Thread Carl Eugen Hoyos
2018-07-19 3:37 GMT+02:00, James Almer : > On 7/18/2018 3:57 PM, Aman Gupta wrote: >> +ret = av_opt_set_from_string(s->bsfs[s->nb_bsfs - >> 1]->priv_data, bsf_options_str, shorthand, "=", ":"); >> +if (ret < 0) { >> +av_log(avctx, AV_LOG_ERROR, "Invalid opti

Re: [FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-19 Thread Aman Gupta
On Wed, Jul 18, 2018 at 6:38 PM James Almer wrote: > On 7/18/2018 3:57 PM, Aman Gupta wrote: > > From: Aman Gupta > > > > avcodec/decode: parse options from AVCodec.bsfs > > > Fixes a bug that would prevent using multiple comma-separated filters, > > and allows options to be passed to each filte

Re: [FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-18 Thread James Almer
On 7/18/2018 3:57 PM, Aman Gupta wrote: > From: Aman Gupta > avcodec/decode: parse options from AVCodec.bsfs > Fixes a bug that would prevent using multiple comma-separated filters, > and allows options to be passed to each filter. > > Based on similar loop in ffmpeg_opt.c's new_output_stream(

[FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-18 Thread Aman Gupta
From: Aman Gupta Fixes a bug that would prevent using multiple comma-separated filters, and allows options to be passed to each filter. Based on similar loop in ffmpeg_opt.c's new_output_stream(). Signed-off-by: Aman Gupta --- libavcodec/decode.c | 47 -