[FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2022-06-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure |1 + libavcodec/Makefile |1 + libavcodec/allcodecs.c |1 + libavcodec/bink2.c | 381 ++ libavcodec/bink2.h | 135 libavcodec/bink2f.h | 1240 libavcodec/bink2g.

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2022-06-01 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-06-01 11:03:28) > "make checkheaders" does the latter. It is not part of the standard fate Any reason it isn't? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2022-06-01 Thread Andreas Rheinhardt
Paul B Mahol: > On Wed, Jun 1, 2022 at 10:57 AM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> Renamed to headers, will apply right now! >> >> In this case you will likely either add these headers to SKIPHEADERS or >> add the necessary headers to them to make

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2022-06-01 Thread Paul B Mahol
On Wed, Jun 1, 2022 at 10:57 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > Renamed to headers, will apply right now! > > In this case you will likely either add these headers to SKIPHEADERS or > add the necessary headers to them to make them standalone. > > Why

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2022-06-01 Thread Andreas Rheinhardt
Paul B Mahol: > Renamed to headers, will apply right now! In this case you will likely either add these headers to SKIPHEADERS or add the necessary headers to them to make them standalone. - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2022-06-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure |1 + libavcodec/Makefile |1 + libavcodec/allcodecs.c |1 + libavcodec/bink2.c | 481 + libavcodec/bink2f.h | 1236 libavcodec/bink2g.h | 1481 +

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2022-06-01 Thread Paul B Mahol
Renamed to headers, will apply right now! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2022-05-28 Thread Andreas Rheinhardt
Paul B Mahol: > Signed-off-by: Paul B Mahol > --- > configure |1 + > libavcodec/Makefile |1 + > libavcodec/allcodecs.c |1 + > libavcodec/bink2.c | 479 + > libavcodec/bink2f.c | 1234 > libavcodec/bink2g.c

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2022-05-25 Thread Tomas Härdin
tis 2022-05-24 klockan 15:36 +0200 skrev Paul B Mahol: > > +    c->current_q = av_malloc_array((avctx->width + 31) / 32, > sizeof(*c->current_q)); > +    if (!c->current_q) > +    return AVERROR(ENOMEM); You can exploit BINK_MAX_WIDTH and BINK_MAX_HEIGHT to make the size of these arrays const

[FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2022-05-24 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure |1 + libavcodec/Makefile |1 + libavcodec/allcodecs.c |1 + libavcodec/bink2.c | 479 + libavcodec/bink2f.c | 1234 libavcodec/bink2g.c | 1479 +

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread Paul B Mahol
On 4/7/20, James Almer wrote: > On 4/7/2020 2:55 PM, Paul B Mahol wrote: >> On 4/7/20, Anton Khirnov wrote: >>> Quoting Paul B Mahol (2020-04-07 16:29:23) On 4/7/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-04-06 16:27:54) >> On 4/6/20, James Almer wrote: >>> On 4/6/20

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread James Almer
On 4/7/2020 2:55 PM, Paul B Mahol wrote: > On 4/7/20, Anton Khirnov wrote: >> Quoting Paul B Mahol (2020-04-07 16:29:23) >>> On 4/7/20, Anton Khirnov wrote: Quoting Paul B Mahol (2020-04-06 16:27:54) > On 4/6/20, James Almer wrote: >> On 4/6/2020 7:01 AM, Paul B Mahol wrote: >>>

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread Paul B Mahol
On 4/7/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-04-07 16:29:23) >> On 4/7/20, Anton Khirnov wrote: >> > Quoting Paul B Mahol (2020-04-06 16:27:54) >> >> On 4/6/20, James Almer wrote: >> >> > On 4/6/2020 7:01 AM, Paul B Mahol wrote: >> >> >> On 3/20/20, Paul B Mahol wrote: >> >> >>>

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread Anton Khirnov
Quoting Paul B Mahol (2020-04-07 16:29:23) > On 4/7/20, Anton Khirnov wrote: > > Quoting Paul B Mahol (2020-04-06 16:27:54) > >> On 4/6/20, James Almer wrote: > >> > On 4/6/2020 7:01 AM, Paul B Mahol wrote: > >> >> On 3/20/20, Paul B Mahol wrote: > >> >>> Signed-off-by: Paul B Mahol > >> >>> --

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread Jean-Baptiste Kempf
On Tue, Apr 7, 2020, at 16:29, Paul B Mahol wrote: > If you are new dictator/leader of FFmpeg There is no dictator and there should not be one. If there was one leader, it would be Michael, because of his involvement and longevity in the project. He denied that role, which is why we're replacin

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread James Almer
On 4/7/2020 11:29 AM, Paul B Mahol wrote: > On 4/7/20, Anton Khirnov wrote: >> Quoting Paul B Mahol (2020-04-06 16:27:54) >>> On 4/6/20, James Almer wrote: On 4/6/2020 7:01 AM, Paul B Mahol wrote: > On 3/20/20, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> c

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread Paul B Mahol
On 4/7/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-04-06 16:27:54) >> On 4/6/20, James Almer wrote: >> > On 4/6/2020 7:01 AM, Paul B Mahol wrote: >> >> On 3/20/20, Paul B Mahol wrote: >> >>> Signed-off-by: Paul B Mahol >> >>> --- >> >>> configure |1 + >> >>> libavc

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread Anton Khirnov
Quoting Paul B Mahol (2020-04-06 16:27:54) > On 4/6/20, James Almer wrote: > > On 4/6/2020 7:01 AM, Paul B Mahol wrote: > >> On 3/20/20, Paul B Mahol wrote: > >>> Signed-off-by: Paul B Mahol > >>> --- > >>> configure |1 + > >>> libavcodec/Makefile |1 + > >>> libavcod

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-06 Thread Paul B Mahol
On 4/6/20, James Almer wrote: > On 4/6/2020 7:01 AM, Paul B Mahol wrote: >> On 3/20/20, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> configure |1 + >>> libavcodec/Makefile |1 + >>> libavcodec/allcodecs.c |1 + >>> libavcodec/avcodec.h|

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-06 Thread James Almer
On 4/6/2020 7:01 AM, Paul B Mahol wrote: > On 3/20/20, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> configure |1 + >> libavcodec/Makefile |1 + >> libavcodec/allcodecs.c |1 + >> libavcodec/avcodec.h|1 + >> libavcodec/bink2.c | 869 +

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-06 Thread Paul B Mahol
On 3/20/20, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure |1 + > libavcodec/Makefile |1 + > libavcodec/allcodecs.c |1 + > libavcodec/avcodec.h|1 + > libavcodec/bink2.c | 869 > libavcodec/bink2f.c

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-21 Thread Peter Ross
On Fri, Mar 20, 2020 at 02:31:05PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure |1 + > libavcodec/Makefile |1 + > libavcodec/allcodecs.c |1 + > libavcodec/avcodec.h|1 + > libavcodec/bink2.c | 869 ++

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-21 Thread Paul B Mahol
On 3/21/20, James Almer wrote: > On 3/20/2020 10:31 AM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> configure |1 + >> libavcodec/Makefile |1 + >> libavcodec/allcodecs.c |1 + >> libavcodec/avcodec.h|1 + >> libavcodec/bink2.c | 869

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-21 Thread Paul B Mahol
On 3/21/20, Nicolas George wrote: > Paul B Mahol (12020-03-21): >> I'm not gonna remove those tables, no matter how "valid" your comments >> are. > > Then you're not gonna apply this patch either. That's how a collective > project works. I'm not listening to your comments. > > -- > Nicolas Geo

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-21 Thread Nicolas George
Paul B Mahol (12020-03-21): > I'm not gonna remove those tables, no matter how "valid" your comments are. Then you're not gonna apply this patch either. That's how a collective project works. -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-21 Thread Paul B Mahol
On 3/21/20, Jan Ekström wrote: > On Fri, Mar 20, 2020 at 3:31 PM Paul B Mahol wrote: >> >> Signed-off-by: Paul B Mahol >> --- > > I am not sure how well I'd be able to review the technicalities, and > thus I only have the following requests: > - Since I didn't see a mention of the current limita

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-21 Thread Jan Ekström
On Fri, Mar 20, 2020 at 3:31 PM Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > --- I am not sure how well I'd be able to review the technicalities, and thus I only have the following requests: - Since I didn't see a mention of the current limitations of this implementation (such as the la

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-21 Thread Jan Ekström
On Sat, Mar 21, 2020 at 1:30 PM Paul B Mahol wrote: > > On 3/21/20, Jan Ekström wrote: > > On Sat, Mar 21, 2020 at 11:27 AM Paul B Mahol wrote: > >> > >> I do not plan to remove any of this, > >> > >> So please refrain from posting such "reviews". > >> > > > > While I have respect for your techn

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-21 Thread Paul B Mahol
On 3/21/20, Jan Ekström wrote: > On Sat, Mar 21, 2020 at 11:27 AM Paul B Mahol wrote: >> >> I do not plan to remove any of this, >> >> So please refrain from posting such "reviews". >> > > While I have respect for your technical capabilities, can you please > refrain from behaving in such a toxic

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-21 Thread Jan Ekström
On Sat, Mar 21, 2020 at 11:27 AM Paul B Mahol wrote: > > I do not plan to remove any of this, > > So please refrain from posting such "reviews". > While I have respect for your technical capabilities, can you please refrain from behaving in such a toxic and off-putting manner? Someone clearly to

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-21 Thread Paul B Mahol
I do not plan to remove any of this, So please refrain from posting such "reviews". On 3/21/20, Peter Ross wrote: > On Fri, Mar 20, 2020 at 02:31:05PM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> configure |1 + >> libavcodec/Makefile |1 + >> l

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-20 Thread James Almer
On 3/20/2020 10:31 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure |1 + > libavcodec/Makefile |1 + > libavcodec/allcodecs.c |1 + > libavcodec/avcodec.h|1 + > libavcodec/bink2.c | 869 > libavcode

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-20 Thread Peter Ross
On Fri, Mar 20, 2020 at 02:31:05PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure |1 + > libavcodec/Makefile |1 + > libavcodec/allcodecs.c |1 + > libavcodec/avcodec.h|1 + > libavcodec/bink2.c | 869 ++

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-20 Thread Vittorio Giovara
On Fri, Mar 20, 2020 at 9:31 AM Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure |1 + > libavcodec/Makefile |1 + > libavcodec/allcodecs.c |1 + > libavcodec/avcodec.h|1 + > libavcodec/bink2.c | 869 >

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-20 Thread James Almer
On 3/20/2020 10:31 AM, Paul B Mahol wrote: > +static av_cold int bink2_decode_end(AVCodecContext *avctx) > +{ > +Bink2Context * const c = avctx->priv_data; > + > +av_frame_free(&c->last); > +av_freep(&c->current_q); > +av_freep(&c->prev_q); > +av_freep(&c->current_dc); > +av