Re: [FFmpeg-devel] [PATCH] avcodec: add a native BBC Dirac VC-2 HQ encoder

2016-01-14 Thread Ganesh Ajjanagadde
On Thu, Jan 14, 2016 at 2:00 PM, Rostislav Pehlivanov wrote: [...] > > Signed-off-by: Rostislav Pehlivanov [...] > + > +#include "diracenc_transforms.h" > + > +#define COEF_LUT_TAB 1024 > + > +typedef struct SubBand { > +int stride; > +int width; > +int height; > +dwtcoef *buf; >

Re: [FFmpeg-devel] [PATCH] avcodec: add a native BBC Dirac VC-2 HQ encoder

2016-01-14 Thread Michael Niedermayer
On Thu, Jan 14, 2016 at 07:00:48PM +, Rostislav Pehlivanov wrote: [...] > +int diracenc_init_transforms(DiracTransforms *s, int p_width, int p_height) [..,] > +void diracenc_deinit_transforms(DiracTransforms *s) either needs to be static or needs prefix [...] -- Michael GnuPG fingerpr

Re: [FFmpeg-devel] [PATCH] avcodec: add a native BBC Dirac VC-2 HQ encoder

2016-01-14 Thread Kieran Kunhya
> +static av_always_inline void coeff_quantize_encode(PutBitContext *pb, qcoef > coeff, > + int qfactor, int qoffset) > +{ > +uint16_t acoef; > +int sign = coeff < 0; FFSIGN > +coeff -= sign; > +coeff ^= -sign; > +coeff <<= 2;

Re: [FFmpeg-devel] [PATCH] avcodec: add a native BBC Dirac VC-2 HQ encoder

2016-01-14 Thread Rostislav Pehlivanov
>There is a typo and please sanitize this: Will be corrected in next revision. They happen, the keys were right next to each other. I blame QWERTY. >If you (also) have copyright, say so, if you are only the author, make a note This is exactly the way the Opus decoder is licensed so I don't think i

Re: [FFmpeg-devel] [PATCH] avcodec: add a native BBC Dirac VC-2 HQ encoder

2016-01-14 Thread Carl Eugen Hoyos
Rostislav Pehlivanov gmail.com> writes: > + * Copyright (C) 2016 Open Broadcast Systemd Ltd. > + * Author(C) 2016 Rostislav Pehlivanov gmail.com> There is a typo and please sanitize this: If you (also) have copyright, say so, if you are only the author, make a note below. Great work! Ca

[FFmpeg-devel] [PATCH] avcodec: add a native BBC Dirac VC-2 HQ encoder

2016-01-14 Thread Rostislav Pehlivanov
This commit adds a new encoder capable of creating BBC Dirac VC-2 HQ profile files. Dirac is a wavelet based codec created by the BBC a little more than 10 years ago. Since then, wavelets have mostly gone out of style as they did not provide adequate encoding gains at lower bitrates. Dirac was a f