[FFmpeg-devel] [PATCH] avcodec: add QDMC decoder

2017-01-05 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Changelog | 1 + doc/general.texi | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/qdmc.c | 789 + 5 files changed, 793 insertions(+) create mode 100644 li

Re: [FFmpeg-devel] [PATCH] avcodec: add QDMC decoder

2017-01-05 Thread James Almer
On 1/5/2017 4:13 PM, Paul B Mahol wrote: >>> +static float sin_table[512]; >>> +static VLC vtable[6]; >> Why are these not part of QDMCContext? > They are static, never change, so having it part of context wastes > memory, with duplicate tables for each instance of decoder. Then i think it might b

Re: [FFmpeg-devel] [PATCH] avcodec: add QDMC decoder

2017-01-05 Thread Lou Logan
On Thu, 5 Jan 2017 19:34:44 +0100, Paul B Mahol wrote: [...] > +++ b/libavcodec/qdmc.c [...] libavcodec/qdmc.c: In function ‘qdmc_decode_frame’: libavcodec/qdmc.c:463:39: warning: array subscript is above array bounds [-Warray-bounds] s->noise[ch][band][idx] = lastval + k *

Re: [FFmpeg-devel] [PATCH] avcodec: add QDMC decoder

2017-01-05 Thread Paul B Mahol
On 1/5/17, James Almer wrote: > On 1/5/2017 3:34 PM, Paul B Mahol wrote: >> diff --git a/libavcodec/qdmc.c b/libavcodec/qdmc.c >> new file mode 100644 >> index 000..5559db3 >> --- /dev/null >> +++ b/libavcodec/qdmc.c >> @@ -0,0 +1,817 @@ >> +/* >> + * QDMC compatible decoder >> + * Copyright (

Re: [FFmpeg-devel] [PATCH] avcodec: add QDMC decoder

2017-01-05 Thread James Almer
On 1/5/2017 3:34 PM, Paul B Mahol wrote: > diff --git a/libavcodec/qdmc.c b/libavcodec/qdmc.c > new file mode 100644 > index 000..5559db3 > --- /dev/null > +++ b/libavcodec/qdmc.c > @@ -0,0 +1,817 @@ > +/* > + * QDMC compatible decoder > + * Copyright (c) 2017 Paul B Mahol > + * > + * This file

[FFmpeg-devel] [PATCH] avcodec: add QDMC decoder

2017-01-05 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Changelog | 1 + doc/general.texi | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/qdmc.c | 817 + 5 files changed, 821 insertions(+) create mode 100644 li