Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-06-02 Thread Piotr Bandurski
Hi, > > 2016-05-30 17:50 GMT+02:00 Paul B Mahol : > > On 5/30/16, Piotr Bandurski wrote: > >> Hi, > >> > >>> patch attached. > >> > >> Is decoding of interlaced video supported? Because I get here invalid > >> output. > >> > >> Also crash happens with this fuzzed file: > >> > >> https://www.dataf

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-06-01 Thread Christophe Gisquet
2016-05-30 17:50 GMT+02:00 Paul B Mahol : > On 5/30/16, Piotr Bandurski wrote: >> Hi, >> >>> patch attached. >> >> Is decoding of interlaced video supported? Because I get here invalid >> output. >> >> Also crash happens with this fuzzed file: >> >> https://www.datafilehost.com/d/c64eb5b1 >> >> Re

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-05-31 Thread Christophe Gisquet
Hi, 2016-05-30 15:09 GMT+02:00 Paul B Mahol : Hi, 2016-05-30 15:09 GMT+02:00 Paul B Mahol : >> ffmpeg seems to have libavutil/qsort.h, but I don't even know how much >> effort is needed to use it here. > > Changed, doesn't help but maybe will for other archs. I have no idea why it is present, bu

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-05-30 Thread Paul B Mahol
On 5/30/16, Piotr Bandurski wrote: >> Updated patch attached. > > There seems to be some bug in interlaced support (related to "Full range > YUV" option in encoder). > > How to reproduce: encode video with enabled "Interlaced" and "Full range > YUV" options together > and then try to decode this w

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-05-30 Thread Piotr Bandurski
> Updated patch attached. There seems to be some bug in interlaced support (related to "Full range YUV" option in encoder). How to reproduce: encode video with enabled "Interlaced" and "Full range YUV" options together and then try to decode this with your latest version of decoder. __

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-05-30 Thread Paul B Mahol
On 5/29/16, Paul B Mahol wrote: > Hi, > > patch attached. > Updated patch attached. From 6986dd8f6ee3625daaa0ff80256e4a353c4268c1 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 22 May 2016 15:18:30 +0200 Subject: [PATCH] avocdec: add MagicYUV decoder Signed-off-by: Paul B Mahol --- li

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-05-30 Thread Paul B Mahol
On 5/30/16, Piotr Bandurski wrote: > Hi, > >> patch attached. > > Is decoding of interlaced video supported? Because I get here invalid > output. Will try to fix it. > > Also crash happens with this fuzzed file: > > https://www.datafilehost.com/d/c64eb5b1 Locally fixed. > > Regards > > ___

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-05-30 Thread Piotr Bandurski
> Can you create YUVA video somehow? I can't with virtualdub. https://www.datafilehost.com/d/49ea26f8 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-05-30 Thread Paul B Mahol
On 5/30/16, Piotr Bandurski wrote: > Hi, > >> patch attached. > > Is decoding of interlaced video supported? Because I get here invalid > output. > > Also crash happens with this fuzzed file: > > https://www.datafilehost.com/d/c64eb5b1 > > Regards Can you create YUVA video somehow? I can't with v

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-05-30 Thread Piotr Bandurski
Hi, > patch attached. Is decoding of interlaced video supported? Because I get here invalid output. Also crash happens with this fuzzed file: https://www.datafilehost.com/d/c64eb5b1 Regards ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-05-30 Thread Paul B Mahol
On 5/30/16, Christophe Gisquet wrote: > Hi, > > 2016-05-29 21:51 GMT+02:00 Paul B Mahol : >> +typedef struct Slice { >> +uint32_t start; >> +uint32_t size; >> +} Slice; > > I'm not a security expert, but is there a reason for not using plain int > there ? I added check for offsets locally

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-05-30 Thread Christophe Gisquet
Hi, 2016-05-29 21:51 GMT+02:00 Paul B Mahol : > +typedef struct Slice { > +uint32_t start; > +uint32_t size; > +} Slice; I'm not a security expert, but is there a reason for not using plain int there ? > +typedef struct MagicYUVContext { > +AVFrame*p; > +int

[FFmpeg-devel] [PATCH] avcodec: add MagicYUV decoder

2016-05-29 Thread Paul B Mahol
Hi, patch attached. From f9f538cc6253f892bb04b7c9e46189194b6f9be4 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 22 May 2016 15:18:30 +0200 Subject: [PATCH] avocdec: add MagicYUV decoder Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + l