Re: [FFmpeg-devel] [PATCH] avcodec: Assert on codec->encode2 in encode_audio2

2015-08-27 Thread Michael Niedermayer
On Thu, Aug 27, 2015 at 12:40:30PM +0200, lummax wrote: > Assert on `avctx->codec->encode2` to avoid a SEGFAULT on the subsequent > function call. > --- > libavcodec/utils.c | 2 ++ > 1 file changed, 2 insertions(+) commit messages extended applied thanks [...] -- Michael GnuPG fingerprint

Re: [FFmpeg-devel] [PATCH] avcodec: Assert on codec->encode2 in encode_audio2

2015-08-27 Thread wm4
On Thu, 27 Aug 2015 12:55:17 +0200 Lukas Blubb wrote: > 2015-08-27 12:45 GMT+02:00 wm4 : > > [..] > > > > When can this happen? Shouldn't it just return an error somewhere if > > this is not an encoder? > > I'm working on a Rust wrapper library and apparently am doing something > wrong (it segfa

Re: [FFmpeg-devel] [PATCH] avcodec: Assert on codec->encode2 in encode_audio2

2015-08-27 Thread Lukas Blubb
2015-08-27 12:45 GMT+02:00 wm4 : > [..] > > When can this happen? Shouldn't it just return an error somewhere if > this is not an encoder? I'm working on a Rust wrapper library and apparently am doing something wrong (it segfaulted). `avcodec_encode_video2()` has this assertion, so I thought it mi

Re: [FFmpeg-devel] [PATCH] avcodec: Assert on codec->encode2 in encode_audio2

2015-08-27 Thread wm4
On Thu, 27 Aug 2015 12:40:30 +0200 lummax wrote: > Assert on `avctx->codec->encode2` to avoid a SEGFAULT on the subsequent > function call. > --- > libavcodec/utils.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index 4da16ee..f51070c 1006

[FFmpeg-devel] [PATCH] avcodec: Assert on codec->encode2 in encode_audio2

2015-08-27 Thread lummax
Assert on `avctx->codec->encode2` to avoid a SEGFAULT on the subsequent function call. --- libavcodec/utils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 4da16ee..f51070c 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1953,6 +19