Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-13 Thread Michael Niedermayer
On Sat, May 13, 2017 at 08:38:52AM +0200, wm4 wrote: > On Fri, 12 May 2017 20:55:13 +0200 > Michael Niedermayer wrote: > > > On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: > > > On 5/12/17, Michael Niedermayer wrote: > > > > On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Nied

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread wm4
On Fri, 12 May 2017 20:55:13 +0200 Michael Niedermayer wrote: > On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: > > On 5/12/17, Michael Niedermayer wrote: > > > On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Niedermayer wrote: > > >> On Thu, May 11, 2017 at 09:01:57AM +0200,

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread wm4
On Fri, 12 May 2017 18:21:07 +0200 Nicolas George wrote: > Le tridi 23 floréal, an CCXXV, Paul B Mahol a écrit : > > I told you that its unacceptable. > > And I told you, before you pushed, that your cowboy-style parser was > unacceptable. You chose to disregard it. AFAIK all of our subtitle

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread Michael Niedermayer
On Fri, May 12, 2017 at 09:13:51PM +0200, Paul B Mahol wrote: > On 5/12/17, Paul B Mahol wrote: > > On 5/12/17, Michael Niedermayer wrote: > >> On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: > >>> On 5/12/17, Michael Niedermayer wrote: > >>> > On Thu, May 11, 2017 at 11:17:33AM +0

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread Michael Niedermayer
On Fri, May 12, 2017 at 08:58:52PM +0200, Paul B Mahol wrote: > On 5/12/17, Michael Niedermayer wrote: > > On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: > >> On 5/12/17, Michael Niedermayer wrote: > >> > On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Niedermayer wrote: > >> >>

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread Paul B Mahol
On 5/12/17, Nicolas George wrote: > Le tridi 23 floreal, an CCXXV, Paul B Mahol a ecrit : >> Because I assumed packets are padded with zeroes. > > Because you chose to write quick-and-dirty instead of robust. Thank you. ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread Nicolas George
Le tridi 23 floréal, an CCXXV, Paul B Mahol a écrit : > Because I assumed packets are padded with zeroes. Because you chose to write quick-and-dirty instead of robust. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffm

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread Paul B Mahol
On 5/12/17, Paul B Mahol wrote: > On 5/12/17, Michael Niedermayer wrote: >> On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: >>> On 5/12/17, Michael Niedermayer wrote: >>> > On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Niedermayer wrote: >>> >> On Thu, May 11, 2017 at 09:01:57A

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread Paul B Mahol
On 5/12/17, Michael Niedermayer wrote: > On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: >> On 5/12/17, Michael Niedermayer wrote: >> > On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Niedermayer wrote: >> >> On Thu, May 11, 2017 at 09:01:57AM +0200, Paul B Mahol wrote: >> >> > On

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread Michael Niedermayer
On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: > On 5/12/17, Michael Niedermayer wrote: > > On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Niedermayer wrote: > >> On Thu, May 11, 2017 at 09:01:57AM +0200, Paul B Mahol wrote: > >> > On 5/11/17, Michael Niedermayer wrote: > >> > >

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread Paul B Mahol
On 5/12/17, Nicolas George wrote: > Le tridi 23 floreal, an CCXXV, Paul B Mahol a ecrit : >> I told you that its unacceptable. > > And I told you, before you pushed, that your cowboy-style parser was > unacceptable. You chose to disregard it. Because I assumed packets are padded with zeroes.

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread Nicolas George
Le tridi 23 floréal, an CCXXV, Paul B Mahol a écrit : > I told you that its unacceptable. And I told you, before you pushed, that your cowboy-style parser was unacceptable. You chose to disregard it. Regards, -- Nicolas George ___ ffmpeg-devel maili

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread Paul B Mahol
On 5/12/17, Michael Niedermayer wrote: > On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Niedermayer wrote: >> On Thu, May 11, 2017 at 09:01:57AM +0200, Paul B Mahol wrote: >> > On 5/11/17, Michael Niedermayer wrote: >> > > Most of these were found through code review in response to >> > > fixi

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread Michael Niedermayer
On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Niedermayer wrote: > On Thu, May 11, 2017 at 09:01:57AM +0200, Paul B Mahol wrote: > > On 5/11/17, Michael Niedermayer wrote: > > > Most of these were found through code review in response to > > > fixing 1466/clusterfuzz-testcase-minimized-5961584

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-11 Thread Michael Niedermayer
On Thu, May 11, 2017 at 09:01:57AM +0200, Paul B Mahol wrote: > On 5/11/17, Michael Niedermayer wrote: > > Most of these were found through code review in response to > > fixing 1466/clusterfuzz-testcase-minimized-5961584419536896 > > There is thus no testcase for most of this. > > The initial iss

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-11 Thread Paul B Mahol
On 5/11/17, Michael Niedermayer wrote: > Most of these were found through code review in response to > fixing 1466/clusterfuzz-testcase-minimized-5961584419536896 > There is thus no testcase for most of this. > The initial issue was Found-by: continuous fuzzing process > https://github.com/google/

[FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-10 Thread Michael Niedermayer
Most of these were found through code review in response to fixing 1466/clusterfuzz-testcase-minimized-5961584419536896 There is thus no testcase for most of this. The initial issue was Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-b