Re: [FFmpeg-devel] [PATCH] avcodec/wmalosslessdec: real 24bit support

2016-04-18 Thread Christophe Gisquet
2016-04-14 7:56 GMT+02:00 Christophe Gisquet : > As Hendrik said, please move it to LLAudDSPContext. So this, and some of my other comments, are already addressed by the final patch which was pushed before my review, making it somewhat moot. Could you please send a message next time indicating it

Re: [FFmpeg-devel] [PATCH] avcodec/wmalosslessdec: real 24bit support

2016-04-13 Thread Christophe Gisquet
Hi, 2016-04-12 22:53 GMT+02:00 Paul B Mahol : > -LLAudDSPContext dsp; ///< accelerated And later: > +static int scalarproduct_and_madd_int(int *v1, const int *v2, > + const int *v3, > + int o

Re: [FFmpeg-devel] [PATCH] avcodec/wmalosslessdec: real 24bit support

2016-04-12 Thread Hendrik Leppkes
On Tue, Apr 12, 2016 at 11:29 PM, Paul B Mahol wrote: > On 4/12/16, Paul B Mahol wrote: >> On 4/12/16, Carl Eugen Hoyos wrote: >>> Paul B Mahol gmail.com> writes: >>> Hi, patch attached. >>> >>> Very cool! >>> -pred += s->dsp.scalarproduct_and_madd_int16(s->cdlm

Re: [FFmpeg-devel] [PATCH] avcodec/wmalosslessdec: real 24bit support

2016-04-12 Thread Paul B Mahol
On 4/12/16, Paul B Mahol wrote: > On 4/12/16, Carl Eugen Hoyos wrote: >> Paul B Mahol gmail.com> writes: >> >>> >>> Hi, >>> >>> patch attached. >> >> Very cool! >> >>> -pred += s->dsp.scalarproduct_and_madd_int16(s->cdlms[ch] >>> +pred += scalarproduct_and_madd_int(s->cdlms[ch][i

Re: [FFmpeg-devel] [PATCH] avcodec/wmalosslessdec: real 24bit support

2016-04-12 Thread Paul B Mahol
On 4/12/16, Carl Eugen Hoyos wrote: > Paul B Mahol gmail.com> writes: > >> >> Hi, >> >> patch attached. > > Very cool! > >> -pred += s->dsp.scalarproduct_and_madd_int16(s->cdlms[ch] >> +pred += scalarproduct_and_madd_int(s->cdlms[ch][ilms].coefs, > > Doesn't this lead to a speedlo

Re: [FFmpeg-devel] [PATCH] avcodec/wmalosslessdec: real 24bit support

2016-04-12 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > > Hi, > > patch attached. Very cool! > -pred += s->dsp.scalarproduct_and_madd_int16(s->cdlms[ch] > +pred += scalarproduct_and_madd_int(s->cdlms[ch][ilms].coefs, Doesn't this lead to a speedloss for 16 bit decoding? Carl Eugen __

[FFmpeg-devel] [PATCH] avcodec/wmalosslessdec: real 24bit support

2016-04-12 Thread Paul B Mahol
Hi, patch attached. From 538f424defabd4ae55467ba216a678e0bb50c12c Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Tue, 12 Apr 2016 22:41:51 +0200 Subject: [PATCH] avcodec/wmalosslessdec: real 24bit support Signed-off-by: Paul B Mahol --- configure | 1 - libavcodec/wmaloss