2017-12-31 18:45 GMT+01:00 Derek Buitenhuis :
> On 12/31/2017 2:04 PM, Carl Eugen Hoyos wrote:
>> This is not helpful;-(
>> Is it so unlikely that the patch has small gain for gbr
>> (theoretically compensated by existing fast conversion
>> from gbr to rgb) but large impact for rgb (with slow
>> co
On 12/31/17, Derek Buitenhuis wrote:
> On 12/31/2017 2:08 PM, Paul B Mahol wrote:
> Why do they change?
> Do I understand correctly that the files get bigger (~5%)?
> If yes, wouldn't that indicate that the patch is not a good idea?
Its because of different scaling path. Have
On 12/31/2017 2:04 PM, Carl Eugen Hoyos wrote:
> This is not helpful;-(
> Is it so unlikely that the patch has small gain for gbr
> (theoretically compensated by existing fast conversion
> from gbr to rgb) but large impact for rgb (with slow
> conversion from rgb into gbr)?
I went and tested the s
On 12/31/2017 2:08 PM, Paul B Mahol wrote:
Why do they change?
Do I understand correctly that the files get bigger (~5%)?
If yes, wouldn't that indicate that the patch is not a good idea?
>>>
>>> Its because of different scaling path. Have nothing to do with
>>> good or bad idea.
>>
On 12/31/2017 2:21 PM, Carl Eugen Hoyos wrote:
> The real-world issue I see is screen-recording.
>
> Given that these are small functions and the obvious user advantage
> I really believe supporting both pix_fmts is the best solution.
Generic RGB packing has no place inside the encoder and decode
2017-12-31 15:16 GMT+01:00 Paul B Mahol :
> On 12/31/17, Carl Eugen Hoyos wrote:
>> 2017-12-31 10:48 GMT+01:00 Paul B Mahol :
>>
>>> static void mangle_rgb_planes(uint8_t *dst[4], ptrdiff_t dst_stride,
>>
>> Why don't you add a new function mangle_gbr_planes() and
>> keep rgb encoding? The functi
On 12/31/17, Carl Eugen Hoyos wrote:
> 2017-12-31 10:48 GMT+01:00 Paul B Mahol :
>
>> static void mangle_rgb_planes(uint8_t *dst[4], ptrdiff_t dst_stride,
>
> Why don't you add a new function mangle_gbr_planes() and
> keep rgb encoding? The function is not very large.
No. UtVideo expect planar r
2017-12-31 10:48 GMT+01:00 Paul B Mahol :
> static void mangle_rgb_planes(uint8_t *dst[4], ptrdiff_t dst_stride,
Why don't you add a new function mangle_gbr_planes() and
keep rgb encoding? The function is not very large.
Carl Eugen
___
ffmpeg-devel ma
On 12/31/17, Carl Eugen Hoyos wrote:
> 2017-12-31 14:49 GMT+01:00 Paul B Mahol :
>> On 12/31/17, Carl Eugen Hoyos wrote:
>>> 2017-12-31 10:48 GMT+01:00 Paul B Mahol :
Signed-off-by: Paul B Mahol
---
libavcodec/utvideoenc.c | 47 +---
tests/ref/fate
2017-12-31 14:49 GMT+01:00 Paul B Mahol :
> On 12/31/17, Carl Eugen Hoyos wrote:
>> 2017-12-31 10:48 GMT+01:00 Paul B Mahol :
>>> Signed-off-by: Paul B Mahol
>>> ---
>>> libavcodec/utvideoenc.c | 47 +---
>>> tests/ref/fate/utvideoenc_rgb_left| 100
>>>
On 12/31/17, Carl Eugen Hoyos wrote:
> 2017-12-31 10:48 GMT+01:00 Paul B Mahol :
>> Signed-off-by: Paul B Mahol
>> ---
>> libavcodec/utvideoenc.c | 47 +---
>> tests/ref/fate/utvideoenc_rgb_left| 100
>> +-
>> tests/ref/fate/utvideoe
2017-12-31 10:48 GMT+01:00 Paul B Mahol :
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/utvideoenc.c | 47 +---
> tests/ref/fate/utvideoenc_rgb_left| 100
> +-
> tests/ref/fate/utvideoenc_rgb_median | 100
> +
Signed-off-by: Paul B Mahol
---
libavcodec/utvideoenc.c | 47 +---
tests/ref/fate/utvideoenc_rgb_left| 100 +-
tests/ref/fate/utvideoenc_rgb_median | 100 +-
tests/ref/fate/utvideoenc_rgb_none| 100
13 matches
Mail list logo
