Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-10 Thread Michael Niedermayer
On Mon, Apr 10, 2017 at 04:14:44PM +0200, Clément Bœsch wrote: > On Mon, Apr 10, 2017 at 04:10:14PM +0200, Clément Bœsch wrote: > > I reverted and I'm in the process of reporting to valgrind. > > Here you go: > https://bugs.kde.org/show_bug.cgi?id=378622 Thanks! [...] -- Michael GnuPG fing

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-10 Thread Clément Bœsch
On Mon, Apr 10, 2017 at 04:10:14PM +0200, Clément Bœsch wrote: > I reverted and I'm in the process of reporting to valgrind. Here you go: https://bugs.kde.org/show_bug.cgi?id=378622 -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-10 Thread Clément Bœsch
On Mon, Apr 10, 2017 at 02:48:51PM +0200, Michael Niedermayer wrote: > On Mon, Apr 10, 2017 at 02:42:42PM +0200, Clément Bœsch wrote: > > On Mon, Apr 10, 2017 at 02:19:54PM +0200, Michael Niedermayer wrote: > > > On Mon, Apr 10, 2017 at 02:04:30PM +0200, Clément Bœsch wrote: > > > > On Mon, Apr 10,

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-10 Thread Michael Niedermayer
On Mon, Apr 10, 2017 at 02:42:42PM +0200, Clément Bœsch wrote: > On Mon, Apr 10, 2017 at 02:19:54PM +0200, Michael Niedermayer wrote: > > On Mon, Apr 10, 2017 at 02:04:30PM +0200, Clément Bœsch wrote: > > > On Mon, Apr 10, 2017 at 01:37:54PM +0200, Michael Niedermayer wrote: > > > > On Mon, Apr 10,

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-10 Thread Clément Bœsch
On Mon, Apr 10, 2017 at 02:19:54PM +0200, Michael Niedermayer wrote: > On Mon, Apr 10, 2017 at 02:04:30PM +0200, Clément Bœsch wrote: > > On Mon, Apr 10, 2017 at 01:37:54PM +0200, Michael Niedermayer wrote: > > > On Mon, Apr 10, 2017 at 08:02:34AM +0200, Clément Bœsch wrote: > > > > On Sun, Apr 09,

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-10 Thread Michael Niedermayer
On Mon, Apr 10, 2017 at 02:04:30PM +0200, Clément Bœsch wrote: > On Mon, Apr 10, 2017 at 01:37:54PM +0200, Michael Niedermayer wrote: > > On Mon, Apr 10, 2017 at 08:02:34AM +0200, Clément Bœsch wrote: > > > On Sun, Apr 09, 2017 at 11:10:16PM -0300, James Almer wrote: > > > [...] > > > > > is this a

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-10 Thread Clément Bœsch
On Mon, Apr 10, 2017 at 01:37:54PM +0200, Michael Niedermayer wrote: > On Mon, Apr 10, 2017 at 08:02:34AM +0200, Clément Bœsch wrote: > > On Sun, Apr 09, 2017 at 11:10:16PM -0300, James Almer wrote: > > [...] > > > > is this a regression ? > > > > > > Fate didn't always complain about this, so it'

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-10 Thread Michael Niedermayer
On Mon, Apr 10, 2017 at 08:02:34AM +0200, Clément Bœsch wrote: > On Sun, Apr 09, 2017 at 11:10:16PM -0300, James Almer wrote: > [...] > > > is this a regression ? > > > > Fate didn't always complain about this, so it's either something > > introduced by a change in our tree, or a valgrind bug intr

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-09 Thread Clément Bœsch
On Sun, Apr 09, 2017 at 11:10:16PM -0300, James Almer wrote: [...] > > is this a regression ? > > Fate didn't always complain about this, so it's either something > introduced by a change in our tree, or a valgrind bug introduced in a > relatively recent version. > > The reports in > http://fate

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-09 Thread James Almer
On 4/9/2017 10:46 PM, Michael Niedermayer wrote: > On Sun, Apr 09, 2017 at 07:51:10AM -0300, James Almer wrote: >> Fixes valgrind warnings about "Use of uninitialised value of size 8" > > how can this be reproduced ? fate-svq1, fate-svq1-headerswap and fate-vsynth{1,2,3,_lena}-svq1 when configure

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-09 Thread Michael Niedermayer
On Sun, Apr 09, 2017 at 07:51:10AM -0300, James Almer wrote: > Fixes valgrind warnings about "Use of uninitialised value of size 8" how can this be reproduced ? is this a regression ? > > Signed-off-by: James Almer > --- > This probably just silences a bunch of false possitives. if thats the

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-09 Thread James Almer
On 4/9/2017 11:51 AM, Kieran Kunhya wrote: > On Sun, 9 Apr 2017 at 14:57 James Almer wrote: > >> Fixes valgrind warnings about "Use of uninitialised value of size 8" >> >> Signed-off-by: James Almer >> --- >> This probably just silences a bunch of false possitives. >> >> libavcodec/svq1dec.c |

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-09 Thread Kieran Kunhya
On Sun, 9 Apr 2017 at 14:57 James Almer wrote: > Fixes valgrind warnings about "Use of uninitialised value of size 8" > > Signed-off-by: James Almer > --- > This probably just silences a bunch of false possitives. > > libavcodec/svq1dec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions

[FFmpeg-devel] [PATCH] avcodec/svq1: zero initialize entries array

2017-04-09 Thread James Almer
Fixes valgrind warnings about "Use of uninitialised value of size 8" Signed-off-by: James Almer --- This probably just silences a bunch of false possitives. libavcodec/svq1dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/svq1dec.c b/libavcodec/svq1dec.c i