Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-06 Thread Michael Niedermayer
On Wed, Sep 06, 2017 at 11:55:41AM +0200, wm4 wrote: > On Tue, 5 Sep 2017 22:14:39 -0300 > James Almer wrote: > > > On 9/5/2017 5:38 AM, wm4 wrote: > > > On Tue, 5 Sep 2017 10:03:11 +0200 > > > Clément Bœsch wrote: > > > > > >> On Mon, Sep 04, 2017 at 08:35:17PM +0200, wm4 wrote: [...] > > >

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-06 Thread Ronald S. Bultje
Hi, On Wed, Sep 6, 2017 at 10:33 AM, James Almer wrote: > But i also agree with him that, currently, the > tree is littered with error messages that go "$spec_field is out of > range" or whatever, and that they have not been seen as an issue before. > He basically argues that wanting to make new

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-06 Thread wm4
On Wed, 6 Sep 2017 11:33:05 -0300 James Almer wrote: > Also, had you also removed the automated merging parts of the code > without waiting for a major bump, if a pre-removal lavf were to send a > packet to a post-removal lavc, the latter would shit the bed with all > the packets full of unexpect

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-06 Thread James Almer
On 9/6/2017 6:55 AM, wm4 wrote: > On Tue, 5 Sep 2017 22:14:39 -0300 > James Almer wrote: > >> On 9/5/2017 5:38 AM, wm4 wrote: >>> On Tue, 5 Sep 2017 10:03:11 +0200 >>> Clément Bœsch wrote: >>> On Mon, Sep 04, 2017 at 08:35:17PM +0200, wm4 wrote: [...] Can't we just remove

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-06 Thread wm4
On Tue, 5 Sep 2017 22:14:39 -0300 James Almer wrote: > On 9/5/2017 5:38 AM, wm4 wrote: > > On Tue, 5 Sep 2017 10:03:11 +0200 > > Clément Bœsch wrote: > > > >> On Mon, Sep 04, 2017 at 08:35:17PM +0200, wm4 wrote: > >> [...] > >> Can't we just remove this codec? It has no use other than c

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-05 Thread James Almer
On 9/5/2017 5:38 AM, wm4 wrote: > On Tue, 5 Sep 2017 10:03:11 +0200 > Clément Bœsch wrote: > >> On Mon, Sep 04, 2017 at 08:35:17PM +0200, wm4 wrote: >> [...] >> Can't we just remove this codec? It has no use other than causing >> potential security issues and maintenance. > >

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-05 Thread Michael Niedermayer
On Tue, Sep 05, 2017 at 07:53:49PM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, Sep 5, 2017 at 7:47 PM, Michael Niedermayer > wrote: > > > ff_dlog() is not part of a user build so a users bug report will not > > contain it at any verbose / debug level. > > > > That is intentional. The messa

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-05 Thread Ronald S. Bultje
Hi, On Tue, Sep 5, 2017 at 7:47 PM, Michael Niedermayer wrote: > ff_dlog() is not part of a user build so a users bug report will not > contain it at any verbose / debug level. > That is intentional. The messages are not meant for end users, since they are not helpful or informative for them.

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-05 Thread Michael Niedermayer
On Tue, Sep 05, 2017 at 07:13:00AM -0400, Ronald S. Bultje wrote: > Hi, > > On Mon, Sep 4, 2017 at 10:11 PM, James Almer wrote: > > > On 9/4/2017 11:00 PM, Ronald S. Bultje wrote: > > > Hi, > > > > > > On Mon, Sep 4, 2017 at 12:11 PM, Michael Niedermayer > > > >> wrote: > > > > > >> if

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-05 Thread Ronald S. Bultje
Hi, On Mon, Sep 4, 2017 at 10:11 PM, James Almer wrote: > On 9/4/2017 11:00 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Mon, Sep 4, 2017 at 12:11 PM, Michael Niedermayer > >> wrote: > > > >> if(type){ > >> +int ld, cbd, crd; > >> pred_mv(s, &mx, &my, 0, left

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-05 Thread wm4
On Tue, 5 Sep 2017 10:03:11 +0200 Clément Bœsch wrote: > On Mon, Sep 04, 2017 at 08:35:17PM +0200, wm4 wrote: > [...] > > > > > Can't we just remove this codec? It has no use other than causing > > > > > potential security issues and maintenance. > > > > > > > > I agree about removing the en

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-05 Thread Clément Bœsch
On Mon, Sep 04, 2017 at 08:35:17PM +0200, wm4 wrote: [...] > > > > Can't we just remove this codec? It has no use other than causing > > > > potential security issues and maintenance. > > > > > > I agree about removing the encoder, but the decoder is needed for > > > existing streams. Unless eve

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-04 Thread James Almer
On 9/4/2017 11:00 PM, Ronald S. Bultje wrote: > Hi, > > On Mon, Sep 4, 2017 at 12:11 PM, Michael Niedermayer > wrote: > >> if(type){ >> +int ld, cbd, crd; >> pred_mv(s, &mx, &my, 0, left, top, tr); >> -l += get_symbol(&s->c, &s->block_state[32], 1); >

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-04 Thread Ronald S. Bultje
Hi, On Mon, Sep 4, 2017 at 12:11 PM, Michael Niedermayer wrote: > if(type){ > +int ld, cbd, crd; > pred_mv(s, &mx, &my, 0, left, top, tr); > -l += get_symbol(&s->c, &s->block_state[32], 1); > +ld = get_symbol(&s->c, &s->block_state[32], 1

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-04 Thread James Almer
On 9/4/2017 3:16 PM, Michael Niedermayer wrote: > On Mon, Sep 04, 2017 at 02:36:45PM -0300, James Almer wrote: >> On 9/4/2017 2:23 PM, wm4 wrote: >>> On Mon, 4 Sep 2017 18:11:44 +0200 >>> Michael Niedermayer wrote: >>> Fixes: Timeout Fixes: 3142/clusterfuzz-testcase-5007853163118592 >>>

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-04 Thread wm4
On Mon, 4 Sep 2017 20:16:20 +0200 Michael Niedermayer wrote: > On Mon, Sep 04, 2017 at 02:36:45PM -0300, James Almer wrote: > > On 9/4/2017 2:23 PM, wm4 wrote: > > > On Mon, 4 Sep 2017 18:11:44 +0200 > > > Michael Niedermayer wrote: > > > > > >> Fixes: Timeout > > >> Fixes: 3142/clusterfuz

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-04 Thread Michael Niedermayer
On Mon, Sep 04, 2017 at 02:36:45PM -0300, James Almer wrote: > On 9/4/2017 2:23 PM, wm4 wrote: > > On Mon, 4 Sep 2017 18:11:44 +0200 > > Michael Niedermayer wrote: > > > >> Fixes: Timeout > >> Fixes: 3142/clusterfuzz-testcase-5007853163118592 > >> > >> Found-by: continuous fuzzing process > >>

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-04 Thread James Almer
On 9/4/2017 2:23 PM, wm4 wrote: > On Mon, 4 Sep 2017 18:11:44 +0200 > Michael Niedermayer wrote: > >> Fixes: Timeout >> Fixes: 3142/clusterfuzz-testcase-5007853163118592 >> >> Found-by: continuous fuzzing process >> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >> Signed-off-by

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-04 Thread Paul B Mahol
On 9/4/17, wm4 wrote: > On Mon, 4 Sep 2017 18:11:44 +0200 > Michael Niedermayer wrote: > >> Fixes: Timeout >> Fixes: 3142/clusterfuzz-testcase-5007853163118592 >> >> Found-by: continuous fuzzing process >> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >> Signed-off-by: Michael N

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-04 Thread wm4
On Mon, 4 Sep 2017 18:11:44 +0200 Michael Niedermayer wrote: > Fixes: Timeout > Fixes: 3142/clusterfuzz-testcase-5007853163118592 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer Wasn't this patch r

[FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

2017-09-04 Thread Michael Niedermayer
Fixes: Timeout Fixes: 3142/clusterfuzz-testcase-5007853163118592 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/snowdec.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletion