Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 12:24 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, Jan 24, 2016 at 12:13 PM, Paul B Mahol wrote: > >> On 1/24/16, Ronald S. Bultje wrote: >> > Hi, >> > >> > On Sun, Jan 24, 2016 at 12:02 PM, Paul B Mahol >> wrote: >> > >> >> On 1/24/16, Paul B Mahol wrote: >> >>

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 12:13 PM, Paul B Mahol wrote: > On 1/24/16, Ronald S. Bultje wrote: > > Hi, > > > > On Sun, Jan 24, 2016 at 12:02 PM, Paul B Mahol wrote: > > > >> On 1/24/16, Paul B Mahol wrote: > >> > On 1/24/16, Ronald S. Bultje wrote: > >> >> Hi, > >> >> > >> >> On Sun, Jan 24

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Paul B Mahol
On 1/24/16, Ronald S. Bultje wrote: > Hi, > > On Sun, Jan 24, 2016 at 12:02 PM, Paul B Mahol wrote: > >> On 1/24/16, Paul B Mahol wrote: >> > On 1/24/16, Ronald S. Bultje wrote: >> >> Hi, >> >> >> >> On Sun, Jan 24, 2016 at 11:41 AM, Paul B Mahol >> wrote: >> >> >> >>> patch attached. >> >> >>

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 12:02 PM, Paul B Mahol wrote: > On 1/24/16, Paul B Mahol wrote: > > On 1/24/16, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Sun, Jan 24, 2016 at 11:41 AM, Paul B Mahol > wrote: > >> > >>> patch attached. > >> > >> > >> I think that's wrong. buf_end is buf_start+s

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Paul B Mahol
On 1/24/16, Paul B Mahol wrote: > On 1/24/16, Ronald S. Bultje wrote: >> Hi, >> >> On Sun, Jan 24, 2016 at 11:41 AM, Paul B Mahol wrote: >> >>> patch attached. >> >> >> I think that's wrong. buf_end is buf_start+size, so if size=1, this >> allows >> writing up to and including buf_start[1], whic

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Hendrik Leppkes
On Sun, Jan 24, 2016 at 5:51 PM, Paul B Mahol wrote: > On 1/24/16, Ronald S. Bultje wrote: >> Hi, >> >> On Sun, Jan 24, 2016 at 11:41 AM, Paul B Mahol wrote: >> >>> patch attached. >> >> >> I think that's wrong. buf_end is buf_start+size, so if size=1, this allows >> writing up to and including

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Paul B Mahol
On 1/24/16, Ronald S. Bultje wrote: > Hi, > > On Sun, Jan 24, 2016 at 11:41 AM, Paul B Mahol wrote: > >> patch attached. > > > I think that's wrong. buf_end is buf_start+size, so if size=1, this allows > writing up to and including buf_start[1], which overflows size=1. Assert happens otherwise w

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 11:41 AM, Paul B Mahol wrote: > patch attached. I think that's wrong. buf_end is buf_start+size, so if size=1, this allows writing up to and including buf_start[1], which overflows size=1. Ronald ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Paul B Mahol
Hi, patch attached. From cdbc09536a21400fd2df1cc7d00d806eae84572a Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 24 Jan 2016 17:39:39 +0100 Subject: [PATCH] avcodec/put_bits: fix off by one Signed-off-by: Paul B Mahol --- libavcodec/put_bits.h | 2 +- 1 file changed, 1 insertion(+), 1