Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Drop support for old nvenc api

2015-03-24 Thread Michael Niedermayer
On Tue, Mar 24, 2015 at 09:34:43AM +, Carl Eugen Hoyos wrote: > rothenpieler.org> writes: > > > + { check_cpp_condition nvEncodeAPI.h "NVENCAPI_MAJOR_VERSION >= 5" || > > + die "ERROR: NVENC API version 4 or older is not supported"; } && > > This needs a Changelog entry (or simila

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Drop support for old nvenc api

2015-03-24 Thread Carl Eugen Hoyos
rothenpieler.org> writes: > + { check_cpp_condition nvEncodeAPI.h "NVENCAPI_MAJOR_VERSION >= 5" || > + die "ERROR: NVENC API version 4 or older is not supported"; } && This needs a Changelog entry (or similar). Sorry, Carl Eugen ___ ffmpeg

[FFmpeg-devel] [PATCH] avcodec/nvenc: Drop support for old nvenc api

2015-03-24 Thread timo
From: Timo Rothenpieler --- configure | 2 ++ libavcodec/nvenc.c | 16 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/configure b/configure index 4827a4d..ede517e 100755 --- a/configure +++ b/configure @@ -4998,6 +4998,8 @@ enabled libxvid &&

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Drop support for old nvenc api

2015-03-24 Thread Timo Rothenpieler
Am 24.03.2015 um 10:03 schrieb Carl Eugen Hoyos: rothenpieler.org> writes: +#if NVENCAPI_MAJOR_VERSION < 5 +#error "NVENC API 4 or older is not supported" +#endif This should be checked in configure imo. Yes, would indeed be better. Could you confirm that the new api is available and t

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Drop support for old nvenc api

2015-03-24 Thread Carl Eugen Hoyos
rothenpieler.org> writes: > +#if NVENCAPI_MAJOR_VERSION < 5 > +#error "NVENC API 4 or older is not supported" > +#endif This should be checked in configure imo. Could you confirm that the new api is available and that it works for all hardware that the old api supported? Carl Eugen ___

[FFmpeg-devel] [PATCH] avcodec/nvenc: Drop support for old nvenc api

2015-03-24 Thread timo
From: Timo Rothenpieler --- libavcodec/nvenc.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 22956b9..7d04afc 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -36,6 +36,10 @@ #include "internal.