Re: [FFmpeg-devel] [PATCH] avcodec/libx265: add support for reordered_opaque

2020-05-19 Thread James Almer
On 5/19/2020 6:40 PM, Derek Buitenhuis wrote: > On 19/05/2020 22:03, James Almer wrote: >> When pic->reordered_opaque is 0 (default value) x265pic.userData will >> remain NULL. This in turn means x265pic_out.userData will also be NULL >> and avctx->reordered_opaque will be set to 0, so it's functio

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: add support for reordered_opaque

2020-05-19 Thread James Almer
On 5/19/2020 5:53 PM, Hendrik Leppkes wrote: > On Tue, May 19, 2020 at 10:45 PM Derek Buitenhuis > wrote: >> >> On 19/05/2020 19:55, James Almer wrote: >>> +if (pic->reordered_opaque) { >> >> If this is meant to be PTS, won't this break on PTS==0? >> > > Well, it won't break anything, sin

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: add support for reordered_opaque

2020-05-19 Thread Hendrik Leppkes
On Tue, May 19, 2020 at 10:45 PM Derek Buitenhuis wrote: > > On 19/05/2020 19:55, James Almer wrote: > > +if (pic->reordered_opaque) { > > If this is meant to be PTS, won't this break on PTS==0? > Well, it won't break anything, since if its not set on the frame, it'll be set to zero when

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: add support for reordered_opaque

2020-05-19 Thread Derek Buitenhuis
On 19/05/2020 22:03, James Almer wrote: > When pic->reordered_opaque is 0 (default value) x265pic.userData will > remain NULL. This in turn means x265pic_out.userData will also be NULL > and avctx->reordered_opaque will be set to 0, so it's functionally the > expected behavior. > This is done to av

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: add support for reordered_opaque

2020-05-19 Thread James Almer
On 5/19/2020 5:18 PM, Derek Buitenhuis wrote: > On 19/05/2020 19:55, James Almer wrote: >> +if (pic->reordered_opaque) { > > If this is meant to be PTS, won't this break on PTS==0? > > - Derek When pic->reordered_opaque is 0 (default value) x265pic.userData will remain NULL. This in turn

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: add support for reordered_opaque

2020-05-19 Thread Derek Buitenhuis
On 19/05/2020 19:55, James Almer wrote: > +if (pic->reordered_opaque) { If this is meant to be PTS, won't this break on PTS==0? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To un

[FFmpeg-devel] [PATCH] avcodec/libx265: add support for reordered_opaque

2020-05-19 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libx265.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 573ecc8cb0..821175c1b6 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -504,6 +504,16 @@ st