On Wed, 24 Oct 2018, James Almer wrote:
On 10/24/2018 6:43 PM, Marton Balint wrote:
On Tue, 23 Oct 2018, Henrik Gramner wrote:
On Tue, Oct 23, 2018 at 3:22 PM Derek Buitenhuis
wrote:
I'd like to point out that this patch or some variant may be required
anyway.
libx264 only uses strtok_
On 10/24/2018 6:43 PM, Marton Balint wrote:
>
>
> On Tue, 23 Oct 2018, Henrik Gramner wrote:
>
>> On Tue, Oct 23, 2018 at 3:22 PM Derek Buitenhuis
>> wrote:
>>> I'd like to point out that this patch or some variant may be required
>>> anyway.
>>>
>>> libx264 only uses strtok_r or strtok_s if av
On Tue, 23 Oct 2018, Henrik Gramner wrote:
On Tue, Oct 23, 2018 at 3:22 PM Derek Buitenhuis
wrote:
I'd like to point out that this patch or some variant may be required anyway.
libx264 only uses strtok_r or strtok_s if available on the platform.
See:
https://git.videolan.org/?p=x264.git;a
On Tue, Oct 23, 2018 at 3:22 PM Derek Buitenhuis
wrote:
> I'd like to point out that this patch or some variant may be required anyway.
>
> libx264 only uses strtok_r or strtok_s if available on the platform.
>
> See:
> https://git.videolan.org/?p=x264.git;a=blob;f=common/osdep.h;h=715ef8a00c01ad
Hi,
On 21/10/2018 15:07, Henrik Gramner wrote:
> Fixed in x264-sandbox. All uses of plain strtok() will be removed from
> x264 in the next push.
>
> I though all of the strtok() uses in x264 had already been converted
> to strtok_r() but apparently that wasn't the case. Sorry about that.
I'd lik
2018-10-22 2:25 GMT+02:00, Marton Balint :
>
> On Sun, 21 Oct 2018, Henrik Gramner wrote:
>
>> Fixed in x264-sandbox. All uses of plain strtok() will be
>> removed from x264 in the next push.
>
> Great, thanks! Can you give us an X264_BUILD number from
> which this will be fixed?
Could you push yo
On Sun, 21 Oct 2018, Henrik Gramner wrote:
Fixed in x264-sandbox. All uses of plain strtok() will be removed from
x264 in the next push.
Great, thanks! Can you give us an X264_BUILD number from which this will
be fixed?
Thanks,
Marton
___
ffmpeg
Fixed in x264-sandbox. All uses of plain strtok() will be removed from
x264 in the next push.
I though all of the strtok() uses in x264 had already been converted
to strtok_r() but apparently that wasn't the case. Sorry about that.
___
ffmpeg-devel maili
On Sat, Oct 20, 2018 at 4:50 PM Vittorio Giovara
wrote:
>
> On Sat, Oct 20, 2018 at 12:30 PM Marton Balint wrote:
>
> >
> >
> > On Sat, 20 Oct 2018, Hendrik Leppkes wrote:
> >
> > > On Sat, Oct 20, 2018 at 12:35 PM Marton Balint wrote:
> > >>
> > >> Libx264 uses strtok which is not thread safe.
On Sat, 20 Oct 2018, Vittorio Giovara wrote:
On Sat, Oct 20, 2018 at 12:30 PM Marton Balint wrote:
On Sat, 20 Oct 2018, Hendrik Leppkes wrote:
> On Sat, Oct 20, 2018 at 12:35 PM Marton Balint wrote:
>>
>> Libx264 uses strtok which is not thread safe. Strtok is used in
>> x264_param_defa
On Sat, Oct 20, 2018 at 12:30 PM Marton Balint wrote:
>
>
> On Sat, 20 Oct 2018, Hendrik Leppkes wrote:
>
> > On Sat, Oct 20, 2018 at 12:35 PM Marton Balint wrote:
> >>
> >> Libx264 uses strtok which is not thread safe. Strtok is used in
> >> x264_param_default_preset in param_apply_tune in x264
On Sat, 20 Oct 2018, Hendrik Leppkes wrote:
On Sat, Oct 20, 2018 at 12:35 PM Marton Balint wrote:
Libx264 uses strtok which is not thread safe. Strtok is used in
x264_param_default_preset in param_apply_tune in x264/common/base.c.
Therefore the flag must be removed.
Fixes ticket #7446.
Si
On Sat, Oct 20, 2018 at 12:35 PM Marton Balint wrote:
>
> Libx264 uses strtok which is not thread safe. Strtok is used in
> x264_param_default_preset in param_apply_tune in x264/common/base.c.
> Therefore the flag must be removed.
>
> Fixes ticket #7446.
>
> Signed-off-by: Marton Balint
> ---
>
Libx264 uses strtok which is not thread safe. Strtok is used in
x264_param_default_preset in param_apply_tune in x264/common/base.c.
Therefore the flag must be removed.
Fixes ticket #7446.
Signed-off-by: Marton Balint
---
libavcodec/libx264.c | 6 ++
1 file changed, 2 insertions(+), 4 delet
14 matches
Mail list logo
