On 11/11/2016 4:01 PM, Timo Rothenpieler wrote:
> -1 and 0 both mean false now, and I left in the option to pass -1 to
> stay compatible with possible 3rd parties who pass it.
Well that's certainly non-obvious...
> So changing to default to 0 doesn't really matter, and I decided to keep
> the pat
> Actually, looking closer, the default is still -1.
>
> Thus either this patch us incorrect, or the default should be changed to be 0.
-1 and 0 both mean false now, and I left in the option to pass -1 to
stay compatible with possible 3rd parties who pass it.
So changing to default to 0 doesn't
On 11/11/2016 3:26 PM, Derek Buitenhuis wrote:
> This patch LGTM.
>
> When I added this option in c981b1145a857c8f962c93b8eecb1c613b20ffe9, the
> type was
> INT, and the default was -1, and it was correct. It was later broken in
> fb99ef0bd39a1859d0e65c6c16caa8e17dd3cfbe. I suggest looking at eve
On 11/11/2016 2:30 PM, Michael Niedermayer wrote:
> if noone adds suport fo the 3rd constant then the patch should
> likely be applied, unless i miss something
This patch LGTM.
When I added this option in c981b1145a857c8f962c93b8eecb1c613b20ffe9, the type
was
INT, and the default was -1, and it
On Thu, Oct 13, 2016 at 05:32:54PM +0200, Michael Niedermayer wrote:
> On Wed, Oct 12, 2016 at 09:57:16PM +0200, Timo Rothenpieler wrote:
> > Currently, it forces IDR frames for both true and false.
> > Not entirely sure what the original idea behind the tri-state bool
> > option is.
> > ---
> > l
On Wed, Oct 12, 2016 at 09:57:16PM +0200, Timo Rothenpieler wrote:
> Currently, it forces IDR frames for both true and false.
> Not entirely sure what the original idea behind the tri-state bool
> option is.
> ---
> libavcodec/libx264.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
On Wed, Oct 12, 2016 at 21:57:16 +0200, Timo Rothenpieler wrote:
> Currently, it forces IDR frames for both true and false.
> Not entirely sure what the original idea behind the tri-state bool
> option is.
The option's default of -1 ("auto") doesn't seem useful either, since
the code doesn't do an
Currently, it forces IDR frames for both true and false.
Not entirely sure what the original idea behind the tri-state bool
option is.
---
libavcodec/libx264.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
index 9e12464..32e767e
