Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Extract extradata directly if available

2020-09-12 Thread Andriy Gelman
On Sat, 12. Sep 14:00, James Almer wrote: > On 9/12/2020 1:32 PM, Derek Buitenhuis wrote: > > On 12/09/2020 16:48, James Almer wrote: > >> No, see https://bugs.chromium.org/p/aomedia/issues/detail?id=2208 > >> > >> aom_codec_get_global_headers() has a bug that hasn't been fixed. That's > >> why i h

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Extract extradata directly if available

2020-09-12 Thread James Almer
On 9/12/2020 1:32 PM, Derek Buitenhuis wrote: > On 12/09/2020 16:48, James Almer wrote: >> No, see https://bugs.chromium.org/p/aomedia/issues/detail?id=2208 >> >> aom_codec_get_global_headers() has a bug that hasn't been fixed. That's >> why i haven't implemented it yet in our wrapper. > > Even if

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Extract extradata directly if available

2020-09-12 Thread Derek Buitenhuis
On 12/09/2020 16:48, James Almer wrote: > No, see https://bugs.chromium.org/p/aomedia/issues/detail?id=2208 > > aom_codec_get_global_headers() has a bug that hasn't been fixed. That's > why i haven't implemented it yet in our wrapper. Even if fixed, shouldn't be still use the BSF anyway, since it

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Extract extradata directly if available

2020-09-12 Thread James Almer
On 9/12/2020 11:39 AM, Andriy Gelman wrote: > From: Andriy Gelman > > Currently a bsf is inserted to extract OBU headers which are propagated > as packet side data. The side data is used in matroska to insert out of > band extradata. > > Support to fetch extradata directly from av1 was added in

[FFmpeg-devel] [PATCH] avcodec/libaomenc: Extract extradata directly if available

2020-09-12 Thread Andriy Gelman
From: Andriy Gelman Currently a bsf is inserted to extract OBU headers which are propagated as packet side data. The side data is used in matroska to insert out of band extradata. Support to fetch extradata directly from av1 was added in commit f8d6a1653476662a7b00a1564afe37516adeba1a in libaom.