Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dwt: Fix left shift of negative number

2022-09-28 Thread Tomas Härdin
tis 2022-09-27 klockan 21:20 +0200 skrev Andreas Rheinhardt: > Tomas Härdin: > > tis 2022-09-27 klockan 13:40 +0200 skrev Andreas Rheinhardt: > > > Tomas Härdin: > > > > tis 2022-09-27 klockan 01:11 +0200 skrev Andreas Rheinhardt: > > > > > Fixes the j2k-dwt FATE-test; also fixes #9945. > > > > > (

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dwt: Fix left shift of negative number

2022-09-27 Thread Andreas Rheinhardt
Tomas Härdin: > tis 2022-09-27 klockan 13:40 +0200 skrev Andreas Rheinhardt: >> Tomas Härdin: >>> tis 2022-09-27 klockan 01:11 +0200 skrev Andreas Rheinhardt: Fixes the j2k-dwt FATE-test; also fixes #9945. (I don't know whether the multiplication can overflow.) >>> >>> The 5/3 transform i

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dwt: Fix left shift of negative number

2022-09-27 Thread Tomas Härdin
tis 2022-09-27 klockan 13:40 +0200 skrev Andreas Rheinhardt: > Tomas Härdin: > > tis 2022-09-27 klockan 01:11 +0200 skrev Andreas Rheinhardt: > > > Fixes the j2k-dwt FATE-test; also fixes #9945. > > > (I don't know whether the multiplication can overflow.) > > > > The 5/3 transform is used in loss

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dwt: Fix left shift of negative number

2022-09-27 Thread Andreas Rheinhardt
Tomas Härdin: > tis 2022-09-27 klockan 01:11 +0200 skrev Andreas Rheinhardt: >> Fixes the j2k-dwt FATE-test; also fixes #9945. >> (I don't know whether the multiplication can overflow.) > > The 5/3 transform is used in lossless mode and therefore shouldn't > overflow for normal use cases. But some

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dwt: Fix left shift of negative number

2022-09-27 Thread Tomas Härdin
tis 2022-09-27 klockan 01:11 +0200 skrev Andreas Rheinhardt: > Fixes the j2k-dwt FATE-test; also fixes #9945. > (I don't know whether the multiplication can overflow.) The 5/3 transform is used in lossless mode and therefore shouldn't overflow for normal use cases. But someone can of course craft

[FFmpeg-devel] [PATCH] avcodec/jpeg2000dwt: Fix left shift of negative number

2022-09-26 Thread Andreas Rheinhardt
Fixes the j2k-dwt FATE-test; also fixes #9945. (I don't know whether the multiplication can overflow.) Signed-off-by: Andreas Rheinhardt --- libavcodec/jpeg2000dwt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/jpeg2000dwt.c b/libavcodec/jpeg2000dwt.c index f2da