Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec Support for PPT marker

2020-03-27 Thread Gautam Ramakrishnan
On Fri, Mar 27, 2020 at 8:30 PM Carl Eugen Hoyos wrote: > > Am Fr., 27. März 2020 um 15:58 Uhr schrieb Gautam Ramakrishnan > : > > > I was a bit apprehensive about removing the jpeg2000_decode_packet() > > function. I had basically split that function into 2 separate ones. > > Should I keep it til

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec Support for PPT marker

2020-03-27 Thread Carl Eugen Hoyos
Am Fr., 27. März 2020 um 15:58 Uhr schrieb Gautam Ramakrishnan : > I was a bit apprehensive about removing the jpeg2000_decode_packet() > function. I had basically split that function into 2 separate ones. > Should I keep it till we add more changes to the decoder or do I > remove it now itself?

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec Support for PPT marker

2020-03-27 Thread Carl Eugen Hoyos
Am Fr., 27. März 2020 um 14:47 Uhr schrieb : > > From: Gautam Ramakrishnan > > This patch adds support for the JPEG2000 PPT marker. This patch hence, > fixes #4610. The patch was tested on the samples posted along with > ticket #4610. Some frames in this sample are now decoded correctly, some sti

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec Support for PPT marker

2020-03-27 Thread Gautam Ramakrishnan
Hi, I was a bit apprehensive about removing the jpeg2000_decode_packet() function. I had basically split that function into 2 separate ones. Should I keep it till we add more changes to the decoder or do I remove it now itself? On Fri, Mar 27, 2020 at 8:03 PM Carl Eugen Hoyos wrote: > > Am Fr.,

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec Support for PPT marker

2020-03-27 Thread Carl Eugen Hoyos
Am Fr., 27. März 2020 um 15:29 Uhr schrieb Carl Eugen Hoyos : > > Am Fr., 27. März 2020 um 14:47 Uhr schrieb : > > > > From: Gautam Ramakrishnan > > > > This patch adds support for the JPEG2000 PPT marker. This patch hence, > > fixes #4610. The patch was tested on the samples posted along with > >

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec Support for PPT marker

2020-03-27 Thread Carl Eugen Hoyos
Am Fr., 27. März 2020 um 14:47 Uhr schrieb : > > From: Gautam Ramakrishnan > > This patch adds support for the JPEG2000 PPT marker. This patch hence, > fixes #4610. The patch was tested on the samples posted along with > ticket #4610. Your patch adds a compile-time warning here, please fix that.

[FFmpeg-devel] [PATCH] avcodec/jpeg2000dec Support for PPT marker

2020-03-27 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support for the JPEG2000 PPT marker. This patch hence, fixes #4610. The patch was tested on the samples posted along with ticket #4610. --- libavcodec/jpeg2000dec.c | 348 +-- 1 file changed, 331 insertions(+), 17 dele