Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-18 Thread Michael Niedermayer
On Sun, Jul 09, 2017 at 02:28:28PM +0200, Clément Bœsch wrote: > On Sat, Jul 08, 2017 at 11:07:48PM +0200, Michael Niedermayer wrote: > [...] > > 5 days passed with no comments and no suggestions on how to implement > > this better. > > does anyone object to the fix as in the patch to be applied ?

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-11 Thread Michael Niedermayer
On Sun, Jul 09, 2017 at 02:28:28PM +0200, Clément Bœsch wrote: > On Sat, Jul 08, 2017 at 11:07:48PM +0200, Michael Niedermayer wrote: > [...] > > 5 days passed with no comments and no suggestions on how to implement > > this better. > > does anyone object to the fix as in the patch to be applied ?

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-09 Thread Clément Bœsch
On Sun, Jul 09, 2017 at 02:28:28PM +0200, Clément Bœsch wrote: [...] > 544 > 00:53:43,780 --> 00:53:45,941 > <> - he calmed himself. > Side note here: "<<" and ">>" are used for « and ». It's important to not break this case IMO. > > 545 > 00:53:46,216 --> 00:53:49,083 > < the hotel is within e

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-09 Thread Clément Bœsch
On Sat, Jul 08, 2017 at 11:07:48PM +0200, Michael Niedermayer wrote: [...] > 5 days passed with no comments and no suggestions on how to implement > this better. > does anyone object to the fix as in the patch to be applied ? misc patterns I found you may want to give a try (note that these are co

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-08 Thread Michael Niedermayer
On Mon, Jul 03, 2017 at 05:50:08PM +0200, Michael Niedermayer wrote: > On Mon, Jul 03, 2017 at 12:40:13PM +0200, wm4 wrote: > > On Sun, 2 Jul 2017 13:43:57 +0200 > > Michael Niedermayer wrote: > > > > > On Sun, Jul 02, 2017 at 01:14:00PM +0200, wm4 wrote: > > > > On Sun, 2 Jul 2017 00:09:42 +020

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-03 Thread Michael Niedermayer
On Mon, Jul 03, 2017 at 12:40:13PM +0200, wm4 wrote: > On Sun, 2 Jul 2017 13:43:57 +0200 > Michael Niedermayer wrote: > > > On Sun, Jul 02, 2017 at 01:14:00PM +0200, wm4 wrote: > > > On Sun, 2 Jul 2017 00:09:42 +0200 > > > Michael Niedermayer wrote: > > > > > > > This reduces the number of s

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-03 Thread Michael Niedermayer
On Mon, Jul 03, 2017 at 11:44:26AM +0200, Paul B Mahol wrote: > On 7/2/17, Michael Niedermayer wrote: > > On Sun, Jul 02, 2017 at 01:14:00PM +0200, wm4 wrote: > >> On Sun, 2 Jul 2017 00:09:42 +0200 > >> Michael Niedermayer wrote: > >> > >> > This reduces the number of strstr() calls per byte > >

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-03 Thread wm4
On Sun, 2 Jul 2017 13:43:57 +0200 Michael Niedermayer wrote: > On Sun, Jul 02, 2017 at 01:14:00PM +0200, wm4 wrote: > > On Sun, 2 Jul 2017 00:09:42 +0200 > > Michael Niedermayer wrote: > > > > > This reduces the number of strstr() calls per byte > > > This diasalows empty tags like '< >' as

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-03 Thread Paul B Mahol
On 7/2/17, Michael Niedermayer wrote: > On Sun, Jul 02, 2017 at 01:14:00PM +0200, wm4 wrote: >> On Sun, 2 Jul 2017 00:09:42 +0200 >> Michael Niedermayer wrote: >> >> > This reduces the number of strstr() calls per byte >> > This diasalows empty tags like '< >' as well as '<' in tags like >> > ''

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-02 Thread Michael Niedermayer
On Sun, Jul 02, 2017 at 01:14:00PM +0200, wm4 wrote: > On Sun, 2 Jul 2017 00:09:42 +0200 > Michael Niedermayer wrote: > > > This reduces the number of strstr() calls per byte > > This diasalows empty tags like '< >' as well as '<' in tags like > > '' > > > > Fixes timeout > > Fixes: 1817/clust

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-02 Thread wm4
On Sun, 2 Jul 2017 00:09:42 +0200 Michael Niedermayer wrote: > This reduces the number of strstr() calls per byte > This diasalows empty tags like '< >' as well as '<' in tags like '' > > Fixes timeout > Fixes: 1817/clusterfuzz-testcase-minimized-5104230530547712 > > Found-by: continuous fuzzi

[FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-01 Thread Michael Niedermayer
This reduces the number of strstr() calls per byte This diasalows empty tags like '< >' as well as '<' in tags like '' Fixes timeout Fixes: 1817/clusterfuzz-testcase-minimized-5104230530547712 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Sig

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-01 Thread Michael Niedermayer
On Fri, May 26, 2017 at 01:08:54PM +0200, wm4 wrote: > On Thu, 25 May 2017 19:32:06 +0200 > Michael Niedermayer wrote: > > > This reduces the number of strstr() calls per byte > > > > Fixes timeout > > Fixes: 1817/clusterfuzz-testcase-minimized-5104230530547712 > > > > Found-by: continuous fuzz

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-05-26 Thread wm4
On Thu, 25 May 2017 19:32:06 +0200 Michael Niedermayer wrote: > This reduces the number of strstr() calls per byte > > Fixes timeout > Fixes: 1817/clusterfuzz-testcase-minimized-5104230530547712 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/

[FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-05-25 Thread Michael Niedermayer
This reduces the number of strstr() calls per byte Fixes timeout Fixes: 1817/clusterfuzz-testcase-minimized-5104230530547712 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/htmlsubtitles.c | 4