Re: [FFmpeg-devel] [PATCH] avcodec/h264_sei: fix H.274 film grain parsing

2021-08-02 Thread Niklas Haas
On Mon, 02 Aug 2021 08:49:49 -0300 James Almer wrote: > On 8/2/2021 7:36 AM, Niklas Haas wrote: > > From: Niklas Haas > > > > The current code has a number of issues: > > 1. The fg_model_id is specified in H.274 as u(2), not u(8) > > Yes, good catch. > > > 2. This SEI has no ue(v) "repetition

Re: [FFmpeg-devel] [PATCH] avcodec/h264_sei: fix H.274 film grain parsing

2021-08-02 Thread James Almer
On 8/2/2021 7:36 AM, Niklas Haas wrote: From: Niklas Haas The current code has a number of issues: 1. The fg_model_id is specified in H.274 as u(2), not u(8) Yes, good catch. 2. This SEI has no ue(v) "repetition period", but a u(1) persistence flag This one however isn't. ITU-T H.264 has

[FFmpeg-devel] [PATCH] avcodec/h264_sei: fix H.274 film grain parsing

2021-08-02 Thread Niklas Haas
From: Niklas Haas The current code has a number of issues: 1. The fg_model_id is specified in H.274 as u(2), not u(8) 2. This SEI has no ue(v) "repetition period", but a u(1) persistence flag Additionally, we can get away with using the non-long version of get_se_golomb() because the SEI spec as