Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-14 Thread Andreas Rheinhardt
Michael Niedermayer: > On Tue, Jul 14, 2020 at 06:10:39PM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> On Mon, Jul 13, 2020 at 09:04:30PM +0200, Tomas Härdin wrote: fre 2020-07-10 klockan 15:48 +0200 skrev Andreas Rheinhardt: > This happened in get_ue_golomb() if the cached

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-14 Thread Michael Niedermayer
On Tue, Jul 14, 2020 at 06:10:39PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Mon, Jul 13, 2020 at 09:04:30PM +0200, Tomas Härdin wrote: > >> fre 2020-07-10 klockan 15:48 +0200 skrev Andreas Rheinhardt: > >>> This happened in get_ue_golomb() if the cached bitstream reader was >

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-14 Thread Andreas Rheinhardt
Michael Niedermayer: > On Mon, Jul 13, 2020 at 09:04:30PM +0200, Tomas Härdin wrote: >> fre 2020-07-10 klockan 15:48 +0200 skrev Andreas Rheinhardt: >>> This happened in get_ue_golomb() if the cached bitstream reader was >>> in >>> use, because there was no check to handle the case of the read valu

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-13 Thread Michael Niedermayer
On Mon, Jul 13, 2020 at 09:04:30PM +0200, Tomas Härdin wrote: > fre 2020-07-10 klockan 15:48 +0200 skrev Andreas Rheinhardt: > > This happened in get_ue_golomb() if the cached bitstream reader was > > in > > use, because there was no check to handle the case of the read value > > not being in the r

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-13 Thread Andreas Rheinhardt
Tomas Härdin: > fre 2020-07-10 klockan 15:48 +0200 skrev Andreas Rheinhardt: >> This happened in get_ue_golomb() if the cached bitstream reader was >> in >> use, because there was no check to handle the case of the read value >> not being in the range 0..8190. >> >> Signed-off-by: Andreas Rheinhard

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-13 Thread Tomas Härdin
fre 2020-07-10 klockan 15:48 +0200 skrev Andreas Rheinhardt: > This happened in get_ue_golomb() if the cached bitstream reader was > in > use, because there was no check to handle the case of the read value > not being in the range 0..8190. > > Signed-off-by: Andreas Rheinhardt > --- > libavcode

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-10 Thread Lynne
Jul 10, 2020, 14:48 by andreas.rheinha...@gmail.com: > This happened in get_ue_golomb() if the cached bitstream reader was in > use, because there was no check to handle the case of the read value > not being in the range 0..8190. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/golomb.h

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-10 Thread Andreas Rheinhardt
Lynne: > Jul 10, 2020, 14:48 by andreas.rheinha...@gmail.com: > >> This happened in get_ue_golomb() if the cached bitstream reader was in >> use, because there was no check to handle the case of the read value >> not being in the range 0..8190. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> l

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-10 Thread Derek Buitenhuis
On 10/07/2020 15:48, Lynne wrote: > That's in an extremely hot path. Any alternatives? Anothe thing of note is that basically nothing in the entire codebase checks the return value of this function. Possibly literally nothing. - Derek ___ ffmpeg-devel m

[FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-10 Thread Andreas Rheinhardt
This happened in get_ue_golomb() if the cached bitstream reader was in use, because there was no check to handle the case of the read value not being in the range 0..8190. Signed-off-by: Andreas Rheinhardt --- libavcodec/golomb.h | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec