Re: [FFmpeg-devel] [PATCH] avcodec/flac: check frame header crc only if requested

2016-12-08 Thread Michael Niedermayer
On Thu, Dec 08, 2016 at 02:45:42PM -0300, James Almer wrote: > On 12/8/2016 9:31 AM, Michael Niedermayer wrote: > > FFmpeg decoders primary usecase is to decode for human consumption > > for this producing the best quality possible and doing so fast is > > the goal. > > The default thus should be t

Re: [FFmpeg-devel] [PATCH] avcodec/flac: check frame header crc only if requested

2016-12-08 Thread dave
> On Dec 8, 2016, at 12:45 PM, James Almer wrote: > > On 12/8/2016 9:31 AM, Michael Niedermayer wrote: >> FFmpeg decoders primary usecase is to decode for human consumption >> for this producing the best quality possible and doing so fast is >> the goal. >> The default thus should be to do check

Re: [FFmpeg-devel] [PATCH] avcodec/flac: check frame header crc only if requested

2016-12-08 Thread James Almer
On 12/8/2016 9:31 AM, Michael Niedermayer wrote: > FFmpeg decoders primary usecase is to decode for human consumption > for this producing the best quality possible and doing so fast is > the goal. > The default thus should be to do checks that improve quality > its probably better if fuzzers disab

Re: [FFmpeg-devel] [PATCH] avcodec/flac: check frame header crc only if requested

2016-12-08 Thread Michael Niedermayer
On Thu, Dec 08, 2016 at 12:33:56AM -0300, James Almer wrote: > It's more consistent with other similar checks in the decoder, and should > help with fuzzing. > > Signed-off-by: James Almer > --- > I could also add an AV_EF_EXPLODE check before aborting, but i figured > that with a frame header cr

[FFmpeg-devel] [PATCH] avcodec/flac: check frame header crc only if requested

2016-12-07 Thread James Almer
It's more consistent with other similar checks in the decoder, and should help with fuzzing. Signed-off-by: James Almer --- I could also add an AV_EF_EXPLODE check before aborting, but i figured that with a frame header crc failure it's pretty much guaranteed the file will be unplayable. libav