Re: [FFmpeg-devel] [PATCH] avcodec/bitstream: use av_assert0 in GET_DATA

2020-12-09 Thread Paul B Mahol
LGTM On Tue, Dec 8, 2020 at 11:41 PM Marvin Scholz wrote: > For builds with asserts disabled, if the default case would ever be > reached it could lead to uninitialized use of variables as v is never > assigned to anything. > > This caused the following clang warning: > > libavcodec/bitstream.

[FFmpeg-devel] [PATCH] avcodec/bitstream: use av_assert0 in GET_DATA

2020-12-08 Thread Marvin Scholz
For builds with asserts disabled, if the default case would ever be reached it could lead to uninitialized use of variables as v is never assigned to anything. This caused the following clang warning: libavcodec/bitstream.c:374:5: warning: variable 'len' is used uninitialized whenever switch