Re: [FFmpeg-devel] [PATCH] avcodec/bitstream: replace qsort with AV_QSORT

2015-10-18 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 10:25 PM, Michael Niedermayer wrote: > On Sat, Oct 17, 2015 at 09:30:01PM -0400, Ganesh Ajjanagadde wrote: >> Commit 3a0a2f33a6c955823fa4fb12c0b49cd29a496659 claims large performance >> advantages for AV_QSORT over libc's qsort. The reason is that I suspect >> that libc's q

Re: [FFmpeg-devel] [PATCH] avcodec/bitstream: replace qsort with AV_QSORT

2015-10-17 Thread Michael Niedermayer
On Sat, Oct 17, 2015 at 09:30:01PM -0400, Ganesh Ajjanagadde wrote: > Commit 3a0a2f33a6c955823fa4fb12c0b49cd29a496659 claims large performance > advantages for AV_QSORT over libc's qsort. The reason is that I suspect > that libc's qsort (at least on non LTO builds, like the typical FFmpeg config) >

Re: [FFmpeg-devel] [PATCH] avcodec/bitstream: replace qsort with AV_QSORT

2015-10-17 Thread Ganesh Ajjanagadde
On Sat, Oct 17, 2015 at 9:30 PM, Ganesh Ajjanagadde wrote: > Commit 3a0a2f33a6c955823fa4fb12c0b49cd29a496659 claims large performance > advantages for AV_QSORT over libc's qsort. The reason is that I suspect > that libc's qsort (at least on non LTO builds, like the typical FFmpeg config) > can't i

[FFmpeg-devel] [PATCH] avcodec/bitstream: replace qsort with AV_QSORT

2015-10-17 Thread Ganesh Ajjanagadde
Commit 3a0a2f33a6c955823fa4fb12c0b49cd29a496659 claims large performance advantages for AV_QSORT over libc's qsort. The reason is that I suspect that libc's qsort (at least on non LTO builds, like the typical FFmpeg config) can't inline the comparison callback: https://stackoverflow.com/questions/5