Re: [FFmpeg-devel] [PATCH] avcodec/arm/sbcenc: save callee preserved vfp registers

2019-07-29 Thread Reimar Döffinger
Seems sensible to me, though extra points if you or someone has numbers on performance impact. To know whether it would be worthwhile to check if it can be optimized... On 28.07.2019, at 23:46, James Cowgill wrote: > When compiling FFmpeg with GCC-9, some very random segfaults were > observed i

[FFmpeg-devel] [PATCH] avcodec/arm/sbcenc: save callee preserved vfp registers

2019-07-28 Thread James Cowgill
When compiling FFmpeg with GCC-9, some very random segfaults were observed in code which had previously called down into the SBC encoder NEON assembly routines. This was caused by these functions clobbering some of the vfp callee saved registers (d8 - d15 aka q4 - q7). GCC was using these registers