Re: [FFmpeg-devel] [PATCH] avcodec/apv_dsp: Fix left-shift of negative value

2025-04-30 Thread Andreas Rheinhardt
Mark Thompson: > On 30/04/2025 19:26, Andreas Rheinhardt wrote: >> Patch attached. >> >> - Andreas > > Hmm, the spec does write exactly this but also defines << as arithmetic left > shift of a two's complement representation so it works. > > Seems fair, LGTM. > > More generally this line is not

Re: [FFmpeg-devel] [PATCH] avcodec/apv_dsp: Fix left-shift of negative value

2025-04-30 Thread Mark Thompson
On 30/04/2025 19:26, Andreas Rheinhardt wrote: > Patch attached. > > - Andreas Hmm, the spec does write exactly this but also defines << as arithmetic left shift of a two's complement representation so it works. Seems fair, LGTM. More generally this line is not robust to extreme values (can in

[FFmpeg-devel] [PATCH] avcodec/apv_dsp: Fix left-shift of negative value

2025-04-30 Thread Andreas Rheinhardt
Patch attached. - Andreas From a33080ab9e500432e816808fbdc42d15b47e7237 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 30 Apr 2025 20:07:35 +0200 Subject: [PATCH] avcodec/apv_dsp: Fix left-shift of negative value Signed-off-by: Andreas Rheinhardt --- libavcodec/apv_dsp.c | 2 +-