Re: [FFmpeg-devel] [PATCH] avcodec/ac3enc: fix undefined negative left shift

2015-10-10 Thread Michael Niedermayer
On Fri, Oct 09, 2015 at 03:59:04PM -0400, Ganesh Ajjanagadde wrote: > This should fix the undefined behavior reported in: > https://trac.ffmpeg.org/ticket/4727. > > I can reproduce this at runtime: simply stick in an abort call in > asym_quant to check if c < 0 and run FATE. I don't know ac3 so I

[FFmpeg-devel] [PATCH] avcodec/ac3enc: fix undefined negative left shift

2015-10-09 Thread Ganesh Ajjanagadde
This should fix the undefined behavior reported in: https://trac.ffmpeg.org/ticket/4727. I can reproduce this at runtime: simply stick in an abort call in asym_quant to check if c < 0 and run FATE. I don't know ac3 so I can't confirm if negative coefficients are intentional, but at the moment they