Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix integer overflow in apply_independent_coupling_fixed()

2018-04-02 Thread Michael Niedermayer
On Sat, Mar 31, 2018 at 09:44:23PM +0200, Michael Niedermayer wrote: > I was not able to reproduce this, this fix is based on just the fuzzer log. > Fixes: 4959/clusterfuzz-testcase-minimized-6035350934781952 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/maste

[FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix integer overflow in apply_independent_coupling_fixed()

2018-03-31 Thread Michael Niedermayer
I was not able to reproduce this, this fix is based on just the fuzzer log. Fixes: 4959/clusterfuzz-testcase-minimized-6035350934781952 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aacdec_fi

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix integer overflow

2015-07-29 Thread Nedeljko Babic
>> for(j = 0; j> -che->ch[0].ret[j] = >> (int32_t)av_clipl_int32((int64_t)che->ch[0].ret[j]<<7)+0x8000; >> -che->ch[1].ret[j] = >> (int32_t)av_clipl_int32((int64_t)che->ch[1].ret[j]<<7)+0x8000; >> +che->c

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix integer overflow

2015-07-29 Thread Michael Niedermayer
Hi On Wed, Jul 29, 2015 at 11:58:43AM +0200, Nedeljko Babic wrote: > Add type cast of result of av_clipl_int32() to 64 bit to avoid overflow in > addition later. > > Fixes fate failure with clang ftrapv. > > Signed-off-by: Nedeljko Babic > --- > libavcodec/aacdec_template.c | 4 ++-- > 1 file

[FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix integer overflow

2015-07-29 Thread Nedeljko Babic
Add type cast of result of av_clipl_int32() to 64 bit to avoid overflow in addition later. Fixes fate failure with clang ftrapv. Signed-off-by: Nedeljko Babic --- libavcodec/aacdec_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aacdec_template.c b/