Re: [FFmpeg-devel] [PATCH] apng: use correct size for output buffer

2015-11-07 Thread Andreas Cadhalpun
On 07.11.2015 00:17, wm4 wrote: > On Fri, 6 Nov 2015 23:56:52 +0100 > Andreas Cadhalpun wrote: >> Attached is a patch increasing the buffer size to 10 and >> adding an assert that s->bpp is not larger. > > I'm find with this, though I'm not (A)PNG maintainer. On 07.11.2015 06:03, Paul B Mahol wr

Re: [FFmpeg-devel] [PATCH] apng: use correct size for output buffer

2015-11-06 Thread Paul B Mahol
On 11/6/15, Andreas Cadhalpun wrote: > On 06.11.2015 22:29, wm4 wrote: >> On Fri, 6 Nov 2015 22:18:04 +0100 >> Andreas Cadhalpun wrote: >> >>> This fixes a stack buffer overflow. >>> >>> Signed-off-by: Andreas Cadhalpun >>> --- >>> libavcodec/pngdec.c | 3 ++- >>> 1 file changed, 2 insertions(+

Re: [FFmpeg-devel] [PATCH] apng: use correct size for output buffer

2015-11-06 Thread wm4
On Fri, 6 Nov 2015 23:56:52 +0100 Andreas Cadhalpun wrote: > On 06.11.2015 22:29, wm4 wrote: > > On Fri, 6 Nov 2015 22:18:04 +0100 > > Andreas Cadhalpun wrote: > > > >> This fixes a stack buffer overflow. > >> > >> Signed-off-by: Andreas Cadhalpun > >> --- > >> libavcodec/pngdec.c | 3 ++- > >

Re: [FFmpeg-devel] [PATCH] apng: use correct size for output buffer

2015-11-06 Thread Andreas Cadhalpun
On 06.11.2015 22:29, wm4 wrote: > On Fri, 6 Nov 2015 22:18:04 +0100 > Andreas Cadhalpun wrote: > >> This fixes a stack buffer overflow. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/pngdec.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/p

Re: [FFmpeg-devel] [PATCH] apng: use correct size for output buffer

2015-11-06 Thread wm4
On Fri, 6 Nov 2015 22:18:04 +0100 Andreas Cadhalpun wrote: > This fixes a stack buffer overflow. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/pngdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c > index 689aa2

[FFmpeg-devel] [PATCH] apng: use correct size for output buffer

2015-11-06 Thread Andreas Cadhalpun
This fixes a stack buffer overflow. Signed-off-by: Andreas Cadhalpun --- libavcodec/pngdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 689aa2b..c974654 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -1010,