Re: [FFmpeg-devel] [PATCH] apedec: ensure blockstodecode is large enough

2015-04-28 Thread Michael Niedermayer
On Tue, Apr 28, 2015 at 11:22:22AM +0200, Andreas Cadhalpun wrote: > On 28.04.2015 03:18, Michael Niedermayer wrote: > > On Mon, Apr 27, 2015 at 11:56:15PM +0200, Andreas Cadhalpun wrote: > >> s->decoded_buffer is allocated with a min_size of: > >> 2 * FFALIGN(blockstodecode, 8) * sizeof(*s->de

Re: [FFmpeg-devel] [PATCH] apedec: ensure blockstodecode is large enough

2015-04-28 Thread Andreas Cadhalpun
On 28.04.2015 03:18, Michael Niedermayer wrote: > On Mon, Apr 27, 2015 at 11:56:15PM +0200, Andreas Cadhalpun wrote: >> s->decoded_buffer is allocated with a min_size of: >> 2 * FFALIGN(blockstodecode, 8) * sizeof(*s->decoded_buffer) >> >> Then it is assigned to s->decoded[0], which is passed a

Re: [FFmpeg-devel] [PATCH] apedec: ensure blockstodecode is large enough

2015-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2015 at 11:56:15PM +0200, Andreas Cadhalpun wrote: > s->decoded_buffer is allocated with a min_size of: > 2 * FFALIGN(blockstodecode, 8) * sizeof(*s->decoded_buffer) > > Then it is assigned to s->decoded[0], which is passed as out buffer to > decode_array_. > > In this fun

[FFmpeg-devel] [PATCH] apedec: ensure blockstodecode is large enough

2015-04-27 Thread Andreas Cadhalpun
s->decoded_buffer is allocated with a min_size of: 2 * FFALIGN(blockstodecode, 8) * sizeof(*s->decoded_buffer) Then it is assigned to s->decoded[0], which is passed as out buffer to decode_array_. In this function 64 elements of the out buffer are written unconditionally and outside the a