Re: [FFmpeg-devel] [PATCH] alac: validate k before using show_bits in decode_scalar

2015-04-23 Thread Michael Niedermayer
On Fri, Apr 24, 2015 at 12:15:23AM +0200, Andreas Cadhalpun wrote: > On 23.04.2015 23:37, Michael Niedermayer wrote: > > On Thu, Apr 23, 2015 at 08:53:29PM +0200, Andreas Cadhalpun wrote: > >> On 23.04.2015 16:37, Michael Niedermayer wrote: > >>> On Wed, Apr 22, 2015 at 06:24:54PM +0200, Andreas Ca

Re: [FFmpeg-devel] [PATCH] alac: validate k before using show_bits in decode_scalar

2015-04-23 Thread Andreas Cadhalpun
On 23.04.2015 23:37, Michael Niedermayer wrote: > On Thu, Apr 23, 2015 at 08:53:29PM +0200, Andreas Cadhalpun wrote: >> On 23.04.2015 16:37, Michael Niedermayer wrote: >>> On Wed, Apr 22, 2015 at 06:24:54PM +0200, Andreas Cadhalpun wrote: >> libavcodec/alac.c | 4 >> 1 file changed, 4 inserti

Re: [FFmpeg-devel] [PATCH] alac: validate k before using show_bits in decode_scalar

2015-04-23 Thread Michael Niedermayer
On Thu, Apr 23, 2015 at 08:53:29PM +0200, Andreas Cadhalpun wrote: > On 23.04.2015 16:37, Michael Niedermayer wrote: > > On Wed, Apr 22, 2015 at 06:24:54PM +0200, Andreas Cadhalpun wrote: > >> The k != 1 case calls show_bits(gb, k), which doesn't make sense if k > >> is 0. > > > > i dont think k =

Re: [FFmpeg-devel] [PATCH] alac: validate k before using show_bits in decode_scalar

2015-04-23 Thread Andreas Cadhalpun
On 23.04.2015 16:37, Michael Niedermayer wrote: > On Wed, Apr 22, 2015 at 06:24:54PM +0200, Andreas Cadhalpun wrote: >> The k != 1 case calls show_bits(gb, k), which doesn't make sense if k >> is 0. > > i dont think k = 0 is allowed > i suggest you check rice_limit when it is set, i assume that is

Re: [FFmpeg-devel] [PATCH] alac: validate k before using show_bits in decode_scalar

2015-04-23 Thread Michael Niedermayer
On Wed, Apr 22, 2015 at 06:24:54PM +0200, Andreas Cadhalpun wrote: > The k != 1 case calls show_bits(gb, k), which doesn't make sense if k > is 0. i dont think k = 0 is allowed i suggest you check rice_limit when it is set, i assume that is the source of k=0 asking for a sample with rice_limit=0 i

[FFmpeg-devel] [PATCH] alac: validate k before using show_bits in decode_scalar

2015-04-22 Thread Andreas Cadhalpun
The k != 1 case calls show_bits(gb, k), which doesn't make sense if k is 0. Signed-off-by: Andreas Cadhalpun --- libavcodec/alac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index ffd2d77..9db690b 100644 --- a/libavcodec/alac.c +++ b/libavcodec/al