Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-15 Thread Steve Lhomme
On Mon, Feb 15, 2016 at 11:39 AM, wm4 wrote: > On Mon, 15 Feb 2016 10:21:19 +0100 > Steve Lhomme wrote: > >> On Mon, Feb 15, 2016 at 10:16 AM, Carl Eugen Hoyos wrote: >> > Steve Lhomme videolabs.io> writes: >> > >> >> I implemented the same change in VLC. >> > >> > From a quick look, you added

Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-15 Thread wm4
On Mon, 15 Feb 2016 10:21:19 +0100 Steve Lhomme wrote: > On Mon, Feb 15, 2016 at 10:16 AM, Carl Eugen Hoyos wrote: > > Steve Lhomme videolabs.io> writes: > > > >> I implemented the same change in VLC. > > > > From a quick look, you added code to the decoder > > wrapper but how is remuxing s

Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-15 Thread Steve Lhomme
On Mon, Feb 15, 2016 at 10:29 AM, Carl Eugen Hoyos wrote: > Steve Lhomme videolabs.io> writes: > >> On Mon, Feb 15, 2016 at 10:23 AM, Carl Eugen Hoyos wrote: >> > Steve Lhomme videolabs.io> writes: >> > >> >> >> I implemented the same change in VLC. >> >> > >> >> > From a quick look, you added c

Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-15 Thread Carl Eugen Hoyos
Steve Lhomme videolabs.io> writes: > On Mon, Feb 15, 2016 at 10:23 AM, Carl Eugen Hoyos wrote: > > Steve Lhomme videolabs.io> writes: > > > >> >> I implemented the same change in VLC. > >> > > >> > From a quick look, you added code to the decoder > >> > wrapper but how is remuxing supposed to wo

Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-15 Thread Steve Lhomme
On Mon, Feb 15, 2016 at 10:23 AM, Carl Eugen Hoyos wrote: > Steve Lhomme videolabs.io> writes: > >> >> I implemented the same change in VLC. >> > >> > From a quick look, you added code to the decoder >> > wrapper but how is remuxing supposed to work? >> >> In VLC ? There's no Matroska muxer so it

Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-15 Thread Carl Eugen Hoyos
Steve Lhomme videolabs.io> writes: > >> I implemented the same change in VLC. > > > > From a quick look, you added code to the decoder > > wrapper but how is remuxing supposed to work? > > In VLC ? There's no Matroska muxer so it would use > the ffmpeg one. I mean remuxing to mov as mentioned

Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-15 Thread Steve Lhomme
On Mon, Feb 15, 2016 at 10:16 AM, Carl Eugen Hoyos wrote: > Steve Lhomme videolabs.io> writes: > >> I implemented the same change in VLC. > > From a quick look, you added code to the decoder > wrapper but how is remuxing supposed to work? In VLC ? There's no Matroska muxer so it would use the ff

Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-15 Thread Carl Eugen Hoyos
Steve Lhomme videolabs.io> writes: > I implemented the same change in VLC. From a quick look, you added code to the decoder wrapper but how is remuxing supposed to work? > But I think it would be better if the decoder works > with the lighter version of the extra data. Why? I mean where woul

Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-15 Thread Steve Lhomme
> Steve Lhomme gmail.com> writes: > >> can be found in such sample >> http://streams.videolan.org/issues/16620/VLCSupportsample.mkv > > The sample works fine here both with current and > old FFmpeg. > I believe it should also work with vlc --demux=ffmpeg It should because the demuxer has to recon

Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-12 Thread Michael Niedermayer
On Fri, Feb 12, 2016 at 05:05:00PM +0100, Steve Lhomme wrote: > From: Steve Lhomme > > -- > can be found in such sample > http://streams.videolan.org/issues/16620/VLCSupportsample.mkv > --- > libavcodec/alac.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) this breaks fate mak

Re: [FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-12 Thread Carl Eugen Hoyos
Steve Lhomme gmail.com> writes: > can be found in such sample > http://streams.videolan.org/issues/16620/VLCSupportsample.mkv The sample works fine here both with current and old FFmpeg. I believe it should also work with vlc --demux=ffmpeg Is vlc supposed to remux alac from mkv to mov? Does

[FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

2016-02-12 Thread Steve Lhomme
From: Steve Lhomme -- can be found in such sample http://streams.videolan.org/issues/16620/VLCSupportsample.mkv --- libavcodec/alac.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index fc8bc96..9c9df8f 100644 --- a/libavcodec/a