Re: [FFmpeg-devel] [PATCH] af_hdcd: Improve HDCD detection

2016-07-23 Thread Burt P.
On Sat, Jul 23, 2016 at 5:41 PM, Michael Niedermayer wrote: > > this looks like 2 unrelated changes > one is improving documentation the other is changing ths detect code > can you split these in 2 patches ? Ok, I've submitted a new set. ___ ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] af_hdcd: Improve HDCD detection

2016-07-23 Thread Michael Niedermayer
On Sun, Jul 17, 2016 at 12:34:12PM -0500, Burt P wrote: > HDCD is only "detected" if a valid code is active in both > channels simultaneously, as described here: > https://hydrogenaud.io/index.php/topic,79427.msg900371.html#msg900371 > > Signed-off-by: Burt P > --- > libavfilter/af_hdcd.c | 34 +

Re: [FFmpeg-devel] [PATCH] af_hdcd: Improve HDCD detection

2016-07-23 Thread Burt P.
It does not fix #5727, it only improves the result for the "HDCD detected" line in the log. To fix #5727, the code has to be changed to process both channels at once, so that target_gain of both channels is known for every processed sample, or at least every segment between HDCD packets. I am atte

Re: [FFmpeg-devel] [PATCH] af_hdcd: Improve HDCD detection

2016-07-21 Thread Carl Eugen Hoyos
Burt P gmail.com> writes: > HDCD is only "detected" if a valid code is active in both > channels simultaneously Does your patch fix ticket #5727? You don't mention this in the ticket... Thank you for looking at this, Carl Eugen ___ ffmpeg-devel maili

[FFmpeg-devel] [PATCH] af_hdcd: Improve HDCD detection

2016-07-17 Thread Burt P
HDCD is only "detected" if a valid code is active in both channels simultaneously, as described here: https://hydrogenaud.io/index.php/topic,79427.msg900371.html#msg900371 Signed-off-by: Burt P --- libavfilter/af_hdcd.c | 34 -- 1 file changed, 24 insertions(+), 1