Re: [FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-13 Thread Michael Niedermayer
On Tue, Aug 12, 2014 at 07:15:11PM -0700, Mark Reid wrote: > On Tue, Aug 12, 2014 at 6:44 PM, Timothy Gu wrote: > > > On Aug 12, 2014 6:29 PM, "Mark Reid" wrote: > > > > > I didn't realize FFmbc was licensed differently :s. I don't know if it > > > helps, (IANAL either) > > > but the same ULs ca

Re: [FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
sorry I didn't label this patch as version 3 I'll resend this correctly On Tue, Aug 12, 2014 at 8:02 PM, Mark Reid wrote: > UL values from libMXF > Fixes Ticket#1554, Ticket#3100 and Ticket#3450 > --- > libavformat/mxf.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/m

[FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
UL values from libMXF Fixes Ticket#1554, Ticket#3100 and Ticket#3450 --- libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index d20ed94..7d30d65 100644 --- a/libavformat/mxf.c +++ b/libavformat/mxf.c @@ -28,6 +28,8 @@ const MXFCodecUL

[FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
Changes since v2: *cleaned up commit message *identified keys as legacy ULs Mark Reid (1): added ULs for demuxing avid media composer mxf files libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.0.0 ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
On Tue, Aug 12, 2014 at 6:44 PM, Timothy Gu wrote: > On Aug 12, 2014 6:29 PM, "Mark Reid" wrote: > > > I didn't realize FFmbc was licensed differently :s. I don't know if it > > helps, (IANAL either) > > but the same ULs can be found in libMXF project, as well as the AAF SDK. > > I'm not sure ho

Re: [FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Timothy Gu
On Aug 12, 2014 6:29 PM, "Mark Reid" wrote: > I didn't realize FFmbc was licensed differently :s. I don't know if it > helps, (IANAL either) > but the same ULs can be found in libMXF project, as well as the AAF SDK. > I'm not sure how to proceed, should I just drop the patch? Just mention libMXF

Re: [FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
On Tue, Aug 12, 2014 at 4:36 PM, Timothy Gu wrote: > On Aug 12, 2014 10:41 AM, "Mark Reid" wrote: > > > I got the ULs from FMbc version of mxf.c > > Isn't FFmbc GPL? You can't use GPL code in LGPL code unless it is not > copyrightable (which ULs probably are, IANAL) or you have author consent.

Re: [FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Timothy Gu
On Aug 12, 2014 10:41 AM, "Mark Reid" wrote: > I got the ULs from FMbc version of mxf.c Isn't FFmbc GPL? You can't use GPL code in LGPL code unless it is not copyrightable (which ULs probably are, IANAL) or you have author consent. [...] Timothy ___

Re: [FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
On Tue, Aug 12, 2014 at 12:06 PM, Carl Eugen Hoyos wrote: > Mark Reid gmail.com> writes: > > > I got the ULs from FMbc version of mxf.c > > Sounds like this could be added to the commit message. > > > I tested it out on the follow media submitted > > by users reporting this problem > > > > ticke

Re: [FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Carl Eugen Hoyos
Mark Reid gmail.com> writes: > I got the ULs from FMbc version of mxf.c Sounds like this could be added to the commit message. > I tested it out on the follow media submitted > by users reporting this problem > > ticket #1554 > ticket #3100 > ticket #3450 Mentioning these tickets in the comm

[FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
hi, This patch enables demuxing fo MXF files generated for or by Avid Media Composer. Avid seems to use different SMPTE universal labels for its video and audio data definitions then ones currently in mxf.c. Also they seem to use a differnt UL for DNxHD Codec ID. I got the ULs from FMbc version

[FFmpeg-devel] [PATCH] added ULs for demuxing avid media composer mxf files

2014-08-12 Thread Mark Reid
--- libavformat/mxf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index d20ed94..8ebfdf2 100644 --- a/libavformat/mxf.c +++ b/libavformat/mxf.c @@ -28,6 +28,8 @@ const MXFCodecUL ff_mxf_data_definition_uls[] = { { { 0x06,0x0E,0x2B,0x34,0x04,0