Re: [FFmpeg-devel] [PATCH] ac3enc: drop a global variable

2020-02-07 Thread James Almer
On 2/7/2020 1:31 PM, Paul B Mahol wrote: > On 1/30/20, Michael Niedermayer wrote: >> On Wed, Jan 29, 2020 at 04:34:48PM +0100, Anton Khirnov wrote: >>> Log the warning message once per encoder instance instead. >>> --- >>> libavcodec/ac3enc.c | 5 ++--- >>> libavcodec/ac3enc.h | 2 ++ >>> 2 files

Re: [FFmpeg-devel] [PATCH] ac3enc: drop a global variable

2020-02-07 Thread Paul B Mahol
On 1/30/20, Michael Niedermayer wrote: > On Wed, Jan 29, 2020 at 04:34:48PM +0100, Anton Khirnov wrote: >> Log the warning message once per encoder instance instead. >> --- >> libavcodec/ac3enc.c | 5 ++--- >> libavcodec/ac3enc.h | 2 ++ >> 2 files changed, 4 insertions(+), 3 deletions(-) > > LGT

Re: [FFmpeg-devel] [PATCH] ac3enc: drop a global variable

2020-01-30 Thread Michael Niedermayer
On Wed, Jan 29, 2020 at 04:34:48PM +0100, Anton Khirnov wrote: > Log the warning message once per encoder instance instead. > --- > libavcodec/ac3enc.c | 5 ++--- > libavcodec/ac3enc.h | 2 ++ > 2 files changed, 4 insertions(+), 3 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] ac3enc: drop a global variable

2020-01-29 Thread Kieran Kunhya
Sent from my mobile device On Wed, 29 Jan 2020, 15:35 Anton Khirnov, wrote: > Log the warning message once per encoder instance instead. > --- > libavcodec/ac3enc.c | 5 ++--- > libavcodec/ac3enc.h | 2 ++ > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/ac3enc.c b

[FFmpeg-devel] [PATCH] ac3enc: drop a global variable

2020-01-29 Thread Anton Khirnov
Log the warning message once per encoder instance instead. --- libavcodec/ac3enc.c | 5 ++--- libavcodec/ac3enc.h | 2 ++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index 25318f8631..7ce17db067 100644 --- a/libavcodec/ac3enc.c +++ b/lib