I forgot to modify the Makefile; I've made the changes in this reply.
flow gg 于2023年12月2日周六 03:50写道：
> Okay, changed and attached
>
> Rémi Denis-Courmont 于2023年12月2日周六 02:38写道：
>
>> Le perjantaina 1. joulukuuta 2023, 20.35.10 EET Rémi Denis-Courmont a
>> écrit :
>> > Le perjantaina 24. marrasku
Okay, changed and attached
Rémi Denis-Courmont 于2023年12月2日周六 02:38写道：
> Le perjantaina 1. joulukuuta 2023, 20.35.10 EET Rémi Denis-Courmont a
> écrit :
> > Le perjantaina 24. marraskuuta 2023, 0.39.39 EET flow gg a écrit :
> > > Okay, changed
> >
> > src/libavcodec/riscv/ac3dsp_init.c: In functi
Le perjantaina 1. joulukuuta 2023, 20.35.10 EET Rémi Denis-Courmont a écrit :
> Le perjantaina 24. marraskuuta 2023, 0.39.39 EET flow gg a écrit :
> > Okay, changed
>
> src/libavcodec/riscv/ac3dsp_init.c: In function ‘ff_ac3dsp_init_riscv’:
> src/libavcodec/riscv/ac3dsp_init.c:39:33: warning: assi
Le perjantaina 24. marraskuuta 2023, 0.39.39 EET flow gg a écrit :
> Okay, changed
src/libavcodec/riscv/ac3dsp_init.c: In function ‘ff_ac3dsp_init_riscv’:
src/libavcodec/riscv/ac3dsp_init.c:39:33: warning: assignment to ‘void (*)
(int32_t *, const float *, size_t)’ {aka ‘void (*)(int *, const floa
Okay, changed
Rémi Denis-Courmont 于2023年11月24日周五 01:09写道：
> Le torstaina 23. marraskuuta 2023, 1.17.03 EET flow gg a écrit :
> > Hello, I saw the new commit "avcodec/ac3dsp: make len a size_t in
> > float_to_fixed24."
> >
> > So I removed the part #if (__riscv_xlen == 64) and restored the patch.
Le torstaina 23. marraskuuta 2023, 1.17.03 EET flow gg a écrit :
> Hello, I saw the new commit "avcodec/ac3dsp: make len a size_t in
> float_to_fixed24."
>
> So I removed the part #if (__riscv_xlen == 64) and restored the patch.
You're not checking for Zba. Also 'bnez' would be more logical than
I modified the temporary test and sent it in "[FFmpeg-devel] [PATCH]
checkasm/ac3dsp: add float_to_fixed24 test".
So the test time results have changed, and I updated them in the patch.
c910
float_to_fixed24_c: 2207.2
float_to_fixed24_rvv_f32: 696.2
flow gg 于2023年11月22日周三 20:00写道：
> c910
>
Hello, I saw the new commit "avcodec/ac3dsp: make len a size_t in
float_to_fixed24."
So I removed the part #if (__riscv_xlen == 64) and restored the patch.
From 3e790fdccd780257f464aa8f8a56a37321ddd429 Mon Sep 17 00:00:00 2001
From: sunyuechi
Date: Wed, 22 Nov 2023 14:57:29 +0800
Subject: [PATCH]
Wow, thank you for reviewing this. I just wanted to see if the function was
working properly. There are so many bugs in the test code ...
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscrib
On 11/22/2023 11:30 AM, flow gg wrote:
How did you test it?
I wrote a test, but it was a bit rough, so I want to modify it before
submitting. I've added it to this reply.
From 08a012d86db51275fd2cda8dd7ad47cc1f1481ce Mon Sep 17 00:00:00 2001
From: sunyuechi
Date: Wed, 22 Nov 2023 14:57:29
On 11/22/2023 1:37 PM, flow gg wrote:
Thank you for your guidance, I finally understand.. How about choosing
manual zero-extension for rv64? I modified the patch.
#if (__riscv_xlen == 64)
slli a2, a2, 32
srli a2, a2, 32
#endif
Please, don't top post.
I think it will be bett
Thank you for your guidance, I finally understand.. How about choosing
manual zero-extension for rv64? I modified the patch.
#if (__riscv_xlen == 64)
slli a2, a2, 32
srli a2, a2, 32
#endif
Rémi Denis-Courmont 于2023年11月22日周三 22:51写道：
>
>
> Le 22 novembre 2023 16:30:44 GMT+02:00,
Le 22 novembre 2023 16:30:44 GMT+02:00, flow gg a écrit :
>> How did you test it?
>
>I wrote a test, but it was a bit rough, so I want to modify it before
>submitting. I've added it to this reply.
>
>> This does not seem according to the C ABI. AFAIK `unsigned` is
>sign-extended.
>
>I'm a bit co
qemu-riscv64 -cpu rv64,v=true,g=true,c=true,zba=true,vlen=128 checkasm
--test=ac3dsp
flow gg 于2023年11月22日周三 22:30写道：
> > How did you test it?
>
> I wrote a test, but it was a bit rough, so I want to modify it before
> submitting. I've added it to this reply.
>
> > This does not seem according to
> How did you test it?
I wrote a test, but it was a bit rough, so I want to modify it before
submitting. I've added it to this reply.
> This does not seem according to the C ABI. AFAIK `unsigned` is
sign-extended.
I'm a bit confused... because this passed in the tests I wrote in qemu.
Maybe ther
Hi,
How did you test it? As per
http://ffmpeg.org/pipermail/ffmpeg-devel/2023-June/310720.html we still don't
have a FATE instance set up with the RISC-V Vector extension. The only testing
consists of my manual runs of checkasm on a K230 board. (We *do* have Zba and
Zbb now though, hence the e
c910
float_to_fixed24_c: 208.2
float_to_fixed24_rvv_f32: 71.5
From 69da974fd0febaa74db4dd551b05172caeefb846 Mon Sep 17 00:00:00 2001
From: sunyuechi
Date: Wed, 22 Nov 2023 14:57:29 +0800
Subject: [PATCH] lavc/ac3dsp: R-V V float_to_fixed24
c910
float_to_fixed24_c: 208.2
float_to_f
17 matches
Mail list logo
