Re: [FFmpeg-devel] [PATCH] aacenc: set default coding tools by profile

2015-09-01 Thread Rostislav Pehlivanov
>static const? Didn't notice that, thanks. >You could consider using the FF_PROFILE_ macros as the array index. Not really feasible without alot of padding: $ git grep FF_PROFILE_MPEG2_ >libavcodec/avcodec.h:#define FF_PROFILE_MPEG2_AAC_LOW 128 >libavcodec/avcodec.h:#define FF_PROFILE_AAC_HE_V2 28

Re: [FFmpeg-devel] [PATCH] aacenc: set default coding tools by profile

2015-09-01 Thread Timothy Gu
On Tue, Sep 1, 2015 at 6:46 PM Rostislav Pehlivanov wrote: > /** > + * List of currently supported profiles, anything not listed isn't > supported. > + */ > > +struct AACProfileOptions aacenc_profiles[] = { > static const? > +{FF_PROFILE_AAC_LOW, > +{ /* Default profile, these

[FFmpeg-devel] [PATCH] aacenc: set default coding tools by profile

2015-09-01 Thread Rostislav Pehlivanov
This commit will enable or disable coding tools by choosing a profile. Each option can be overriden individually (e.g. disable PNS with AAC-Main profile). The drawback is that "-help encoder=aac" will no longer list the actual defaults, but instead print "-1" for the default values of options. Thi