Re: [FFmpeg-devel] [PATCH] aacenc: remove unsupported PCE mappings

2018-10-21 Thread pkv.stream
Le 29/08/2018 à 1:01 AM, Rostislav Pehlivanov a écrit : On 28 August 2018 at 22:29, Rostislav Pehlivanov > wrote: Turns out those ones make the decoder unable to accurately determine the layout, hence making some API users' guess, and sometimes those

Re: [FFmpeg-devel] [PATCH] aacenc: remove unsupported PCE mappings

2018-08-30 Thread Carl Eugen Hoyos
2018-08-30 23:12 GMT+02:00, Michael Niedermayer : > On Tue, Aug 28, 2018 at 10:29:37PM +0100, Rostislav Pehlivanov wrote: >> Turns out those ones make the decoder unable to accurately determine the >> layout, hence making some API users' guess, and sometimes those are >> correct >> (ffmpeg.c), but

Re: [FFmpeg-devel] [PATCH] aacenc: remove unsupported PCE mappings

2018-08-30 Thread Michael Niedermayer
On Tue, Aug 28, 2018 at 10:29:37PM +0100, Rostislav Pehlivanov wrote: > Turns out those ones make the decoder unable to accurately determine the > layout, hence making some API users' guess, and sometimes those are correct > (ffmpeg.c), but most often (especially with side channels) they're wrong.

Re: [FFmpeg-devel] [PATCH] aacenc: remove unsupported PCE mappings

2018-08-28 Thread Rostislav Pehlivanov
On 28 August 2018 at 22:29, Rostislav Pehlivanov wrote: > Turns out those ones make the decoder unable to accurately determine the > layout, hence making some API users' guess, and sometimes those are correct > (ffmpeg.c), but most often (especially with side channels) they're wrong. > The remove

[FFmpeg-devel] [PATCH] aacenc: remove unsupported PCE mappings

2018-08-28 Thread Rostislav Pehlivanov
Turns out those ones make the decoder unable to accurately determine the layout, hence making some API users' guess, and sometimes those are correct (ffmpeg.c), but most often (especially with side channels) they're wrong. The removed ones need to be investigated into as to why the decoder rejects