Re: [FFmpeg-devel] [PATCH] aacenc: avoid double in quantize_bands.

2016-03-06 Thread Reimar Döffinger
On Wed, Mar 02, 2016 at 07:33:31PM +, Rostislav Pehlivanov wrote: > On 1 March 2016 at 21:55, Reimar Döffinger wrote: > > I cannot see any point whatsoever to use > > double here instead of float. > > Using float allows for use of SIMD. > > --- > > libavcodec/aacenc_utils.h | 5 ++--- > > 1 f

Re: [FFmpeg-devel] [PATCH] aacenc: avoid double in quantize_bands.

2016-03-02 Thread Rostislav Pehlivanov
On 1 March 2016 at 21:55, Reimar Döffinger wrote: > I cannot see any point whatsoever to use > double here instead of float. > Using float allows for use of SIMD. > --- > libavcodec/aacenc_utils.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/aacenc_uti

Re: [FFmpeg-devel] [PATCH] aacenc: avoid double in quantize_bands.

2016-03-01 Thread Reimar Döffinger
On 02.03.2016, at 04:48, Ganesh Ajjanagadde wrote: > On Tue, Mar 1, 2016 at 4:55 PM, Reimar Döffinger > wrote: >> I cannot see any point whatsoever to use >> double here instead of float. > > There can be some negligible accuracy differences, but I do not see > any harm myself; aac anyway stick

Re: [FFmpeg-devel] [PATCH] aacenc: avoid double in quantize_bands.

2016-03-01 Thread Ganesh Ajjanagadde
On Tue, Mar 1, 2016 at 4:55 PM, Reimar Döffinger wrote: > I cannot see any point whatsoever to use > double here instead of float. There can be some negligible accuracy differences, but I do not see any harm myself; aac anyway sticks to floats in most places. > Using float allows for use of SIMD

[FFmpeg-devel] [PATCH] aacenc: avoid double in quantize_bands.

2016-03-01 Thread Reimar Döffinger
I cannot see any point whatsoever to use double here instead of float. Using float allows for use of SIMD. --- libavcodec/aacenc_utils.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/aacenc_utils.h b/libavcodec/aacenc_utils.h index cb5bc8d..571b1e6 100644 ---