Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-27 Thread Nicolas George
Le decadi 30 brumaire, an CCXXV, Clement Boesch a écrit : > Right, I'll probably need that for the sub2video filter. I'll think about > it unless you want to implement it yourself. As always, for me, time is the limiting factor. For now, I believe the only urgent thing to do is to decide what thes

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-21 Thread wm4
On Sun, 20 Nov 2016 13:52:02 +0100 Clément Bœsch wrote: > On Fri, Nov 11, 2016 at 04:46:51PM +0100, wm4 wrote: > [...] > > > + > > > +frame->sub_start_display = sub.start_display_time ? > > > av_rescale_q(sub.start_display_time, av_make_q(1, 1000), AV_TIME_BASE_Q) > > > +

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-21 Thread Carl Eugen Hoyos
2016-11-21 12:30 GMT+01:00 wm4 : > On Sun, 20 Nov 2016 14:24:00 +0100 > Carl Eugen Hoyos wrote: > >> 2016-11-20 13:52 GMT+01:00 Clément Bœsch : >> >> >> > +static const AVOption sbuffer_options[] = { >> >> > +{ "time_base", NULL, OFFSET(time_base), >> >> > AV_OPT_TYPE_RATIONAL, { .dbl =

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-21 Thread wm4
On Sun, 20 Nov 2016 14:24:00 +0100 Carl Eugen Hoyos wrote: > 2016-11-20 13:52 GMT+01:00 Clément Bœsch : > > >> > +static const AVOption sbuffer_options[] = { > >> > +{ "time_base", NULL, OFFSET(time_base), AV_OPT_TYPE_RATIONAL, > >> > { .dbl = 0 }, 0, INT_MAX, S }, > >> > +{ "form

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-20 Thread Carl Eugen Hoyos
2016-11-20 13:52 GMT+01:00 Clément Bœsch : >> > +static const AVOption sbuffer_options[] = { >> > +{ "time_base", NULL, OFFSET(time_base), AV_OPT_TYPE_RATIONAL, { >> > .dbl = 0 }, 0, INT_MAX, S }, >> > +{ "format", NULL, OFFSET(sub_format), AV_OPT_TYPE_INT, { >> > .i64

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-20 Thread Clément Bœsch
On Fri, Nov 11, 2016 at 12:45:03PM +0100, Nicolas George wrote: > Le septidi 17 brumaire, an CCXXV, Clement Boesch a écrit : > > I didn't. Duration is somehow broken currently for some reason. I did > > nothing for sparseness: the reason I added basic support in lavfi is > > because it was much sim

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-20 Thread Clément Bœsch
On Fri, Nov 11, 2016 at 04:46:51PM +0100, wm4 wrote: [...] > > +// TODO: delete this compatibility code when all subtitles encoders moved > > +// to send_frame > > +static int encode_subtitle_frame(AVCodecContext *avctx, > > + AVPacket *avpkt, > > +

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-11 Thread wm4
On Wed, 2 Nov 2016 23:09:34 +0100 Clément Bœsch wrote: > --- > So this is just a prototype that is starting to work. It needs a split > (and completion of the long TODO list) before review but I wanted to > share it for early feedbacks. > > So long story short: AVSubtitle → AVFrame, you have to

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-11 Thread Nicolas George
Le primidi 21 brumaire, an CCXXV, wm4 a écrit : > I'm saying that a good solution is application-specific. It depends on > the exact data flow depending on what kind of filter graph is used. The library should still try to make things as simple as possible. > libavfilter still doesn't know whethe

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-11 Thread wm4
On Fri, 11 Nov 2016 15:36:04 +0100 Nicolas George wrote: > > It seems to me that not libavfilter should handle this, but the one > > which feeds libavfilter. > > Its collaboration is mandatory. But the bulk of the work should be done > by the library, not duplicated in all applications. I'm s

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-11 Thread Nicolas George
Le primidi 21 brumaire, an CCXXV, wm4 a écrit : > OK, let's think about alternative approaches. How about not trying to > let libavfilter do synchronizing subtitles and other streams in all > cases? Why not just send nothing to the subtitle buffer sources if the > subtitles are sparse and there is

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-11 Thread wm4
On Fri, 11 Nov 2016 13:45:54 +0100 Nicolas George wrote: > Le primidi 21 brumaire, an CCXXV, wm4 a écrit : > > No, but I'm confident that you can find one after having thought about > > the problem for so long. > > Well, I have thought about it for long, and not only is this the > solution I h

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-11 Thread Nicolas George
Le primidi 21 brumaire, an CCXXV, wm4 a écrit : > No, but I'm confident that you can find one after having thought about > the problem for so long. Well, I have thought about it for long, and not only is this the solution I have found, but I do not think it is a "bad idea" at all. And I would rea

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-11 Thread wm4
On Fri, 11 Nov 2016 12:49:31 +0100 Nicolas George wrote: > Le primidi 21 brumaire, an CCXXV, wm4 a écrit : > > Sounds like a bad idea. > > Do you have a better one? No, but I'm confident that you can find one after having thought about the problem for so long.

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-11 Thread Nicolas George
Le primidi 21 brumaire, an CCXXV, wm4 a écrit : > Sounds like a bad idea. Do you have a better one? signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-11 Thread wm4
On Fri, 11 Nov 2016 12:45:03 +0100 Nicolas George wrote: > Le septidi 17 brumaire, an CCXXV, Clement Boesch a écrit : > > I didn't. Duration is somehow broken currently for some reason. I did > > nothing for sparseness: the reason I added basic support in lavfi is > > because it was much simpler

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-11 Thread Nicolas George
Le septidi 17 brumaire, an CCXXV, Clement Boesch a écrit : > I didn't. Duration is somehow broken currently for some reason. I did > nothing for sparseness: the reason I added basic support in lavfi is > because it was much simpler to handle at ffmpeg.c level, so it's currently > just a passthrough

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-11 Thread Clément Bœsch
(sorry for initially replying in private by mistake) On Thu, Nov 03, 2016 at 07:36:29PM +0100, Nicolas George wrote: > Le duodi 12 brumaire, an CCXXV, Clement Boesch a écrit : > > --- > > So this is just a prototype that is starting to work. It needs a split > > (and completion of the long TODO li

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-07 Thread Clément Bœsch
On Thu, Nov 03, 2016 at 01:05:01AM +0100, Marton Balint wrote: [...] > > So long story short: AVSubtitle → AVFrame, you have to use the new M:N > > API, and it's integrated into lavfi. > > > > Now a bit longer: the AVFrame->extended_data are > > AVFrameSubtitleRectangle (declared in lavu/frame). >

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-03 Thread Nicolas George
Le duodi 12 brumaire, an CCXXV, Clement Boesch a écrit : > --- > So this is just a prototype that is starting to work. It needs a split > (and completion of the long TODO list) before review but I wanted to > share it for early feedbacks. > > So long story short: AVSubtitle → AVFrame, you have to

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-02 Thread Marton Balint
On Wed, 2 Nov 2016, Clément Bœsch wrote: --- So this is just a prototype that is starting to work. It needs a split (and completion of the long TODO list) before review but I wanted to share it for early feedbacks. Great, thanks! So long story short: AVSubtitle → AVFrame, you have to use th

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-02 Thread Carl Eugen Hoyos
2016-11-02 23:09 GMT+01:00 Clément Bœsch : > - find a test case for dvbsub Please elaborate;-) Thanks for working on this, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-02 Thread Clément Bœsch
On Wed, Nov 02, 2016 at 11:11:06PM +0100, Carl Eugen Hoyos wrote: > 2016-11-02 23:09 GMT+01:00 Clément Bœsch : > > > - find a test case for dvbsub > > Please elaborate;-) > I need a FATE test involving dvb transcoding. -- Clément B. ___ ffmpeg-devel

[FFmpeg-devel] [PATCH] WIP: subtitles in AVFrame

2016-11-02 Thread Clément Bœsch
--- So this is just a prototype that is starting to work. It needs a split (and completion of the long TODO list) before review but I wanted to share it for early feedbacks. So long story short: AVSubtitle → AVFrame, you have to use the new M:N API, and it's integrated into lavfi. Now a bit longe