Thanks for the comments, I'll update my next patch to take that into
account.
But first I wanted to discuss your second point (regarding int64_t/uint64_t
choice).
I have actually looked at all places that use AVStream::id (34 files under
libavformat/ + a few more files outside it). There are a few
Yeah, I was using Gmail web interface, it does that. I'll try attaching the
patch file next time.
On Thu, Mar 10, 2016 at 1:23 AM, Moritz Barsnick wrote:
> On Wed, Mar 09, 2016 at 15:56:53 -0800, Sergey Volk wrote:
> > -if (fmt_ctx->iformat->flags & AVFMT_SHOW_IDS) print_fmt("id",
> > "0
On Wed, Mar 09, 2016 at 15:56:53 -0800, Sergey Volk wrote:
> -if (fmt_ctx->iformat->flags & AVFMT_SHOW_IDS) print_fmt("id",
> "0x%x", stream->id);
> +#if FF_API_OLD_INT32_STREAM_ID
> +#define STREAM_ID_FORMAT "0x%x"
> +#else
> +#define STREAM_ID_FORMAT "0x%"PRIx64
> +#endif
> +if (fmt_c
Thanks for the patch.
Le decadi 20 ventôse, an CCXXIV, Sergey Volk a écrit :
> I have also bumped the major version to 58 locally in version.h, and
> re-ran make with the stream id being int64_t and fixed all new
> warnings that showed up (only saw new warnings related to the
> incorrect format be
From: Sergey Volk
Date: Wed, 9 Mar 2016 14:34:19 -0800
Subject: [PATCH] Change AVStream::id to int64_t in the next version bump
I have also bumped the major version to 58 locally in version.h, and
re-ran make with the stream id being int64_t and fixed all new
warnings that showed up (only saw new
Ok, so then I guess we'll need to update AVStream::id to be 64-bit
first, and then I'll make the necessary changes in matroskadec.
I've prepared a patch to bump AVStream::id to be int64_t in the next
major version, I'll send it out shortly. After I rebuilt ffmpeg
with AVStream::id being int64_t I g
On Fri, Mar 04, 2016 at 04:19:18PM -0800, Sergey Volk wrote:
> Ok, something like this for now, then?
your original patch contained a nice commit message, this one
doesnt
> I'm new to ffmpeg development. When is the next version bump going to happen?
you can make changes at the next bump by usi
Ok, something like this for now, then?
I'm new to ffmpeg development. When is the next version bump going to happen?
---
libavformat/matroskadec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
index d20568c..4c3e53a 100644
--- a/libavf
wm4 googlemail.com> writes:
> > +st->id = (int) track->num;
> Might be better after all not to set the id if it's out of range?
Yes, please.
While there, the id field could be changed to 64bit with the
next version bump.
Carl Eugen
___
ffm
On Wed, 2 Mar 2016 15:29:21 -0800
Sergey Volk wrote:
> As far as I can see FFmpeg currently doesn't set AVStream::id for
> matroska/webm streams. I think we could use either MatroskaTrack::num
> (TrackNumber) or MatroskaTrack::uid (TrackUID) for that.
> I have found a few discussions claiming tha
As far as I can see FFmpeg currently doesn't set AVStream::id for
matroska/webm streams. I think we could use either MatroskaTrack::num
(TrackNumber) or MatroskaTrack::uid (TrackUID) for that.
I have found a few discussions claiming that TrackUID could be missing,
even though TrackUID is marked as
11 matches
Mail list logo
