Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number

2018-03-25 Thread sanilraut
Thanks. @Jan: I will look into the FATE tests. I have emailed you a few questions that I have about FATE. Looking forward to your reply. @Michael: I have added the prefix and resubmitted the patch. Regards, Sanil On Fri, Mar 23, 2018 at 5:24 PM, Michael Niedermayer wrote: > On Thu, Mar 22, 20

Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number

2018-03-23 Thread Michael Niedermayer
On Thu, Mar 22, 2018 at 10:14:36PM +0200, Jan Ekström wrote: > On Thu, Mar 22, 2018 at 9:51 PM, sanilraut wrote: > > Last segment indicated by mpd is not parsed. > > Example stream: > > http://dash.akamaized.net/dash264/TestCasesIOP41/LastSegmentNumber/1/manifest_last_segment_num.mpd > > > > This

Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number

2018-03-23 Thread M M
Thanks. I have re-submitted the patch with changes. On Wed, Mar 21, 2018 at 1:24 PM, Carl Eugen Hoyos wrote: > 2018-03-21 16:33 GMT+01:00, sanilraut : > > > +if(pls->last_seq_no == 0){ > > Please add a space to avoid mixing styles: "if (" > We usually use "if (!pls->last_seq_no)", same abov

Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number

2018-03-22 Thread Jan Ekström
On Thu, Mar 22, 2018 at 9:51 PM, sanilraut wrote: > Last segment indicated by mpd is not parsed. > Example stream: > http://dash.akamaized.net/dash264/TestCasesIOP41/LastSegmentNumber/1/manifest_last_segment_num.mpd > > This patch supports parsing of Supplemental Descriptor with @schemeIdUri set

[FFmpeg-devel] [PATCH] Support signaling of last segment number

2018-03-22 Thread sanilraut
Last segment indicated by mpd is not parsed. Example stream: http://dash.akamaized.net/dash264/TestCasesIOP41/LastSegmentNumber/1/manifest_last_segment_num.mpd This patch supports parsing of Supplemental Descriptor with @schemeIdUri set to http://dashif.org/guide- lines/last-segment-number with

Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number

2018-03-21 Thread Carl Eugen Hoyos
2018-03-21 16:33 GMT+01:00, sanilraut : > +if(pls->last_seq_no == 0){ Please add a space to avoid mixing styles: "if (" We usually use "if (!pls->last_seq_no)", same above. > +pls->last_seq_no = calc_max_seg_no(pls, s->priv_data); > +} Carl Eugen

[FFmpeg-devel] [PATCH] Support signaling of last segment number

2018-03-21 Thread sanilraut
Last segment indicated by mpd is not parsed. Example stream: http://dash.akamaized.net/dash264/TestCasesIOP41/LastSegmentNumber/1/manifest_last_segment_num.mpd This patch supports parsing of Supplemental Descriptor with @schemeIdUri set to http://dashif.org/guide- lines/last-segment-number with