Re: [FFmpeg-devel] [PATCH] Newtek SpeedHQ decoder.

2017-01-08 Thread Steinar H. Gunderson
On Sun, Jan 08, 2017 at 01:45:07PM +0100, Paul B Mahol wrote: >> +memcpy(rbuf, buf, buf_size); >> +memset(rbuf + buf_size, 0, AV_INPUT_BUFFER_PADDING_SIZE); > Huh?!? Is this needed at all? After some discussion on IRC: It turns out that avcodec_decode_video2() requires the input AVPacket t

Re: [FFmpeg-devel] [PATCH] Newtek SpeedHQ decoder.

2017-01-08 Thread Steinar H. Gunderson
On Sun, Jan 08, 2017 at 02:29:22PM +0100, Carl Eugen Hoyos wrote: >> But after YLC, there's PSD and PIXLET, so those would move around? >> Or should it go below those two, too? > Definitely. Moved it there in v2. Forgot to link to this: https://wiki.multimedia.cx/index.php/SpeedHQ Will probably b

Re: [FFmpeg-devel] [PATCH] Newtek SpeedHQ decoder.

2017-01-08 Thread Carl Eugen Hoyos
2017-01-08 14:16 GMT+01:00 Steinar H. Gunderson : > On Sun, Jan 08, 2017 at 02:10:15PM +0100, Carl Eugen Hoyos wrote: Wrong place, put it after YLC, bellow. >>> Will move. What's the intended ordering here, really? >> Important thing is not to change ids of >> existing codecs. > > But after YL

Re: [FFmpeg-devel] [PATCH] Newtek SpeedHQ decoder.

2017-01-08 Thread Steinar H. Gunderson
On Sun, Jan 08, 2017 at 02:10:15PM +0100, Carl Eugen Hoyos wrote: >>> Wrong place, put it after YLC, bellow. >> Will move. What's the intended ordering here, really? > Important thing is not to change ids of > existing codecs. But after YLC, there's PSD and PIXLET, so those would move around? Or s

Re: [FFmpeg-devel] [PATCH] Newtek SpeedHQ decoder.

2017-01-08 Thread Paul B Mahol
On 1/8/17, Steinar H. Gunderson wrote: > On Sun, Jan 08, 2017 at 01:45:07PM +0100, Paul B Mahol wrote: >>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >>> index ca8b786077..23e1ecc7a7 100644 >>> --- a/libavcodec/avcodec.h >>> +++ b/libavcodec/avcodec.h >>> @@ -388,6 +388,14 @@ enum AV

Re: [FFmpeg-devel] [PATCH] Newtek SpeedHQ decoder.

2017-01-08 Thread Carl Eugen Hoyos
2017-01-08 13:55 GMT+01:00 Steinar H. Gunderson : > On Sun, Jan 08, 2017 at 01:45:07PM +0100, Paul B Mahol wrote: >>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >>> index ca8b786077..23e1ecc7a7 100644 >>> --- a/libavcodec/avcodec.h >>> +++ b/libavcodec/avcodec.h >>> @@ -388,6 +388,14

Re: [FFmpeg-devel] [PATCH] Newtek SpeedHQ decoder.

2017-01-08 Thread Steinar H. Gunderson
On Sun, Jan 08, 2017 at 01:45:07PM +0100, Paul B Mahol wrote: >> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h >> index ca8b786077..23e1ecc7a7 100644 >> --- a/libavcodec/avcodec.h >> +++ b/libavcodec/avcodec.h >> @@ -388,6 +388,14 @@ enum AVCodecID { >> AV_CODEC_ID_DXV, >> AV_C

Re: [FFmpeg-devel] [PATCH] Newtek SpeedHQ decoder.

2017-01-08 Thread Paul B Mahol
On 1/8/17, Steinar H. Gunderson wrote: > This decoder can decode all existing SpeedHQ formats (SHQ0-5, 7, and 9), > including correct decoding of the alpha channel. > > 1080p is decoded in 142 fps on one core of my i7-4600U (2.1 GHz Haswell), > about evenly split between bitstream reader and IDCT.

Re: [FFmpeg-devel] [PATCH] Newtek SpeedHQ decoder.

2017-01-08 Thread Steinar H. Gunderson
On Sun, Jan 08, 2017 at 01:33:08PM +0100, Carl Eugen Hoyos wrote: > I would have expected one decoder that checks codec_tag as utvideodec does. Sure, I can do that. Just switch on avctx->codec_tag and MKTAG()? /* Steinar */ -- Homepage: https://www.sesse.net/

Re: [FFmpeg-devel] [PATCH] Newtek SpeedHQ decoder.

2017-01-08 Thread Carl Eugen Hoyos
2017-01-08 12:07 GMT+01:00 Steinar H. Gunderson : > +AVCodec ff_shq0_decoder = { > +AVCodec ff_shq1_decoder = { ... I would have expected one decoder that checks codec_tag as utvideodec does. Great work! Carl Eugen ___ ffmpeg-devel mailing list ffmp

[FFmpeg-devel] [PATCH] Newtek SpeedHQ decoder.

2017-01-08 Thread Steinar H. Gunderson
This decoder can decode all existing SpeedHQ formats (SHQ0–5, 7, and 9), including correct decoding of the alpha channel. 1080p is decoded in 142 fps on one core of my i7-4600U (2.1 GHz Haswell), about evenly split between bitstream reader and IDCT. There is currently no attempt at slice or frame