Re: [FFmpeg-devel] [PATCH] NVENC: Update check for Lookahead

2016-12-26 Thread James Almer
On 12/26/2016 11:33 AM, Timo Rothenpieler wrote: > LGTM > > Can't push from here right now, so if someone could do that, feel free. > Otherwise ping me in like a week if I forget. Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffm

Re: [FFmpeg-devel] [PATCH] NVENC: Update check for Lookahead

2016-12-26 Thread Timo Rothenpieler
LGTM Can't push from here right now, so if someone could do that, feel free. Otherwise ping me in like a week if I forget. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] NVENC: Update check for Lookahead

2016-12-25 Thread Ruta Gadkari
Found one small bug in NVENC implementation. The value of rc_lookahead is initialized to -1 but the check in nvenc.c checks for (ctx->rc_lookahead) rather than (ctx->rc_lookahead > 0). This results in incorrect consideration that lookahead is enabled all the time. Please review this patch which u