On Mon, Nov 21, 2016 at 12:17:43 +0100, Miroslav Slugeň wrote:
> + "Defined rc_lookahead require more surfaces, "
Nit:^ requires
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http:/
Thx, i has same opinion :)
Miroslav Slugeň
+420 724 825 885
Dne 21.11.2016 v 12:57 Timo Rothenpieler napsal(a):
Please split the patch into two (or three) patches to make
the review and possible regression tests easier.
The bug was implicitly fixed by the new code, it doesn't seem necessary
to
> Please split the patch into two (or three) patches to make
> the review and possible regression tests easier.
The bug was implicitly fixed by the new code, it doesn't seem necessary
to me to fix it independently, specially as so far nobody seems to have
run into it.
Patch LGTM, applied locally,
2016-11-21 12:17 GMT+01:00 Miroslav Slugeň :
> That was the easy part, now littlebit more...
>
> Next part of this patch is to always prefer rc_lookahead
[...]
> There were also bug
Please split the patch into two (or three) patches to make
the review and possible regression tests easier.
Than
User selectable surfaces are not working correctly, if you set number of
surfaces on cmdline, it will always use minimum 32 or 48 depends on
selected resolution, but in nvenc it is not necessary to use so many
surfaces.
So from now you can define as low as 1 surface and nvenc will still
work,
