Re: [FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-13 Thread Reimar Döffinger
On 13.03.2016, at 19:11, Ganesh Ajjanagadde wrote: > On Sun, Mar 13, 2016 at 1:46 PM, Reimar Döffinger > wrote: >> >>> >>> --enable-hardcoded-tables partially does that; it increases memory >>> usage as tables are burnt into the library at some gains for >>> initialization time. >> >> No, exa

Re: [FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-13 Thread Ganesh Ajjanagadde
On Sun, Mar 13, 2016 at 1:46 PM, Reimar Döffinger wrote: > On Sun, Mar 13, 2016 at 01:27:52PM -0400, Ganesh Ajjanagadde wrote: >> On Sun, Mar 13, 2016 at 1:21 PM, Reimar Döffinger >> wrote: >> >> > I don't understand the waste; the double init anyway needs to be done, >> >> > all tables are deriv

Re: [FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-13 Thread Reimar Döffinger
On Sun, Mar 13, 2016 at 01:27:52PM -0400, Ganesh Ajjanagadde wrote: > On Sun, Mar 13, 2016 at 1:21 PM, Reimar Döffinger > wrote: > >> > I don't understand the waste; the double init anyway needs to be done, > >> > all tables are derived from it. This dates to an approach I did in > >> > commit: 0

Re: [FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-13 Thread Ganesh Ajjanagadde
On Sun, Mar 13, 2016 at 1:21 PM, Reimar Döffinger wrote: > On Sun, Mar 13, 2016 at 06:14:18PM +0100, Reimar Döffinger wrote: >> On Sun, Mar 13, 2016 at 01:12:57PM -0400, Ganesh Ajjanagadde wrote: >> > On Sun, Mar 13, 2016 at 12:49 PM, Reimar Döffinger >> > wrote: >> > > On Sun, Mar 13, 2016 at 12

Re: [FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-13 Thread Reimar Döffinger
On Sun, Mar 13, 2016 at 06:14:18PM +0100, Reimar Döffinger wrote: > On Sun, Mar 13, 2016 at 01:12:57PM -0400, Ganesh Ajjanagadde wrote: > > On Sun, Mar 13, 2016 at 12:49 PM, Reimar Döffinger > > wrote: > > > On Sun, Mar 13, 2016 at 12:24:25PM -0400, Ganesh Ajjanagadde wrote: > > >> On Sat, Mar 12,

Re: [FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-13 Thread Reimar Döffinger
On Sun, Mar 13, 2016 at 01:12:57PM -0400, Ganesh Ajjanagadde wrote: > On Sun, Mar 13, 2016 at 12:49 PM, Reimar Döffinger > wrote: > > On Sun, Mar 13, 2016 at 12:24:25PM -0400, Ganesh Ajjanagadde wrote: > >> On Sat, Mar 12, 2016 at 1:24 PM, Reimar Döffinger > >> wrote: > >> > for (i = 0;

Re: [FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-13 Thread Reimar Döffinger
On Sun, Mar 13, 2016 at 05:53:10PM +0100, Reimar Döffinger wrote: > On Sun, Mar 13, 2016 at 05:50:17PM +0100, Hendrik Leppkes wrote: > > On Sun, Mar 13, 2016 at 5:24 PM, Ganesh Ajjanagadde > > wrote: > > >> @@ -75,9 +66,8 @@ static av_cold void AAC_RENAME(cbrt_tableinit)(void) > > >> } >

Re: [FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-13 Thread Ganesh Ajjanagadde
On Sun, Mar 13, 2016 at 12:49 PM, Reimar Döffinger wrote: > On Sun, Mar 13, 2016 at 12:24:25PM -0400, Ganesh Ajjanagadde wrote: >> On Sat, Mar 12, 2016 at 1:24 PM, Reimar Döffinger >> wrote: >> > for (i = 0; i < 1<<13; i++) >> > -cbrt_tab[i] = CBRT(cbrt_tab_dbl[i]); >> > +

Re: [FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-13 Thread Reimar Döffinger
On Sun, Mar 13, 2016 at 05:50:17PM +0100, Hendrik Leppkes wrote: > On Sun, Mar 13, 2016 at 5:24 PM, Ganesh Ajjanagadde > wrote: > >> @@ -75,9 +66,8 @@ static av_cold void AAC_RENAME(cbrt_tableinit)(void) > >> } > >> > >> for (i = 0; i < 1<<13; i++) > >> -cbrt_tab[i]

Re: [FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-13 Thread Reimar Döffinger
On Sun, Mar 13, 2016 at 12:24:25PM -0400, Ganesh Ajjanagadde wrote: > On Sat, Mar 12, 2016 at 1:24 PM, Reimar Döffinger > wrote: > > for (i = 0; i < 1<<13; i++) > > -cbrt_tab[i] = CBRT(cbrt_tab_dbl[i]); > > +AAC_RENAME(ff_cbrt_tab)[i] = CBRT(cbrt_tab_dbl[i]); > >

Re: [FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-13 Thread Hendrik Leppkes
On Sun, Mar 13, 2016 at 5:24 PM, Ganesh Ajjanagadde wrote: > On Sat, Mar 12, 2016 at 1:24 PM, Reimar Döffinger > wrote: >> Allows sharing and reusing the data between different files. >> >> Signed-off-by: Reimar Döffinger >> --- >> libavcodec/Makefile | 10 +- >> libavco

Re: [FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-13 Thread Ganesh Ajjanagadde
On Sat, Mar 12, 2016 at 1:24 PM, Reimar Döffinger wrote: > Allows sharing and reusing the data between different files. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/Makefile | 10 +- > libavcodec/aacdec.c | 2 +- > libavcodec/aacdec_fixed.c

[FFmpeg-devel] [PATCH] Move cbrt tables to a separate cbrt_data(_fixed).c files.

2016-03-12 Thread Reimar Döffinger
Allows sharing and reusing the data between different files. Signed-off-by: Reimar Döffinger --- libavcodec/Makefile | 10 +- libavcodec/aacdec.c | 2 +- libavcodec/aacdec_fixed.c | 6 +++--- libavcodec/aacdec_template.c| 4 ++-- libav